You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2019/07/29 05:03:33 UTC
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#9931: feat: (effectScatter) add rippleEffect.color
Ovilia commented on a change in pull request #9931: feat: (effectScatter) add rippleEffect.color
URL: https://github.com/apache/incubator-echarts/pull/9931#discussion_r308056335
##########
File path: src/chart/helper/EffectSymbol.js
##########
@@ -38,13 +38,14 @@ function normalizeSymbolSize(symbolSize) {
}
function updateRipplePath(rippleGroup, effectCfg) {
+ const color = effectCfg.rippleEffectColor || effectCfg.color
Review comment:
`;` at the end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org