You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:21:57 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39045: [MINOR][SQL] Change the group of `ArraySize` from `collection_funcs` to `array_funcs`

HyukjinKwon commented on code in PR #39045:
URL: https://github.com/apache/spark/pull/39045#discussion_r1046787821


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -158,7 +158,7 @@ object Size {
        4
   """,
   since = "3.3.0",
-  group = "collection_funcs")

Review Comment:
   We should actually replace all of `collection_funcs` case: https://github.com/apache/spark/blob/af1dba7ca501fd9372b158793119163e3fcd1f24/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java#L110-L116



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org