[superset] branch master updated: chore(dashboard_rbac): remove overlapping security tests (#12848)

[vi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new bc0198b  chore(dashboard_rbac): remove overlapping security tests (#12848)
bc0198b is described below

commit bc0198b405ac87b34d3a446093a903cad6208886
Author: Amit Miran <47...@users.noreply.github.com>
AuthorDate: Wed Feb 3 19:28:42 2021 +0200

    chore(dashboard_rbac): remove overlapping security tests (#12848)
    
    * chore: remove some security tests that already covered in the rbac and dataset tests
    
    * revert: test is not overlapping
---
 tests/dashboards/api_tests.py | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/tests/dashboards/api_tests.py b/tests/dashboards/api_tests.py
index 38ce1ae..0baea27 100644
--- a/tests/dashboards/api_tests.py
+++ b/tests/dashboards/api_tests.py
@@ -472,27 +472,6 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
         buf.seek(0)
         return buf
 
-    def test_get_dashboards_no_data_access(self):
-        """
-        Dashboard API: Test get dashboards no data access
-        """
-        admin = self.get_user("admin")
-        dashboard = self.insert_dashboard("title", "slug1", [admin.id])
-
-        self.login(username="gamma")
-        arguments = {
-            "filters": [{"col": "dashboard_title", "opr": "sw", "value": "ti"}]
-        }
-        uri = f"api/v1/dashboard/?q={prison.dumps(arguments)}"
-        rv = self.client.get(uri)
-        self.assertEqual(rv.status_code, 200)
-        data = json.loads(rv.data.decode("utf-8"))
-        self.assertEqual(data["count"], 0)
-
-        # rollback changes
-        db.session.delete(dashboard)
-        db.session.commit()
-
     def test_delete_dashboard(self):
         """
         Dashboard API: Test delete