You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/03/07 00:31:09 UTC
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12686
to review the following change.
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
---
M docs/known_issues.adoc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/12686/1
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 2:
updated rendering
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:38:46 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:39:33 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 1:
Rendering at https://github.com/mpercy/kudu/blob/binary-jar-docs-1/docs/known_issues.adoc
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:31:23 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc@191
PS1, Line 191: and
> extra word
Done
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc@191
PS1, Line 191: RapidJSON
> Do you think it's worth adding the current RapidJSON version? In case we fo
Done
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:38:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 2: Code-Review-2
I just checked to see if (kMinInt32 + 1) was incorrectly recognized as an unsigned integer by RapidJSON 0.11, and it's not. So I think it's safe to say that these issues are such a corner cases that we can just fix it in Kudu 1.10.0 without adding it as a known issue for 1.9.0, especially since in all the cases I can think of, Kudu is parsing the JSON based on a strongly-typed protobuf schema and therefore would not be trying to do type inference on the incoming JSON document.
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 18:44:53 +0000
Gerrit-HasComments: No
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc@191
PS1, Line 191: RapidJSON
Do you think it's worth adding the current RapidJSON version? In case we forget about this, it might be obvious from looking through some code whether this is resolved or not.
Though having the jira around serves the same purpose, so feel free to punt.
http://gerrit.cloudera.org:8080/#/c/12686/1/docs/known_issues.adoc@191
PS1, Line 191: and
extra word
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 00:35:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12686
to look at the new patch set (#2).
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
---
M docs/known_issues.adoc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/12686/2
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12686/2/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/12686/2/docs/known_issues.adoc@189
PS2, Line 189: unit tests
> Does this have any effect outside of unit tests though? If we can't articul
I'm not sure yet. I'll try to carve out some time to test this tomorrow.
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 06:48:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Patch Set 2:
(1 comment)
FWIW I've +2'ed Yingchun's patch that upgrades RapidJSON to 1.1.0, so we're pretty close to making this a non-issue for master. Do you want to commit this directly to branch-1.9.x instead, to avoid having to revert it on master once the RapidJSON upgrade is done?
http://gerrit.cloudera.org:8080/#/c/12686/2/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/12686/2/docs/known_issues.adoc@189
PS2, Line 189: unit tests
Does this have any effect outside of unit tests though? If we can't articulate the effect on the product, I don't think we should document this.
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 07 Mar 2019 02:02:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/12686 )
Change subject: docs: KUDU-2716: Document RapidJSON parsing bug as a known issue
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/12686
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I45091bcb7929c7c0977ef0577852e60f1a814214
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>