[GitHub] [iotdb] qiaojialin commented on a change in pull request #1783: Remove unnecessary lock in MManager

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #1783:
URL: https://github.com/apache/iotdb/pull/1783#discussion_r501437166



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -1121,7 +970,6 @@ public StorageGroupMNode getStorageGroupNodeByPath(PartialPath path) throws Meta
    */
   public MNode getDeviceNodeWithAutoCreateAndReadLock(
       PartialPath path, boolean autoCreateSchema, int sgLevel) throws MetadataException {

Review comment:
       fixed

##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -1205,25 +1039,16 @@ public String getDeviceId(PartialPath path) {
     return device;
   }
 
+  // concurrent warning: you should get parent read lock before calling this method

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org