You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/02 21:01:44 UTC

[GitHub] [beam] tysonjh opened a new pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

tysonjh opened a new pull request #15122:
URL: https://github.com/apache/beam/pull/15122


   Reverts apache/beam#15049


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] aromanenko-dev edited a comment on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
aromanenko-dev edited a comment on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874133687


   @tysonjh Could you elaborate why #15049 should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874912975


   > @tysonjh Could you elaborate why #15049 should be reverted?
   
   I am investigating flakiness of the beam_PostCommit_SQL job. I'm not sure it should be reverted, but a "draft" PR is an easy way to check this on the Jenkins infra.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] aromanenko-dev edited a comment on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
aromanenko-dev edited a comment on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874133687


   @tysonjh Could you elaborate why #15049 should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-875776181


   @aromanenko-dev I think we need to revert. There are timeouts in testSQLSelectsArrayAttributes that only started after the PR was merged (see BEAM-12571), this draft PR hasn't had a single timeout in that test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-875798031


   False alarm! Someone pointed out to me that the test has been flaky for a while,
   
   https://issues.apache.org/jira/plugins/servlet/mobile#issue/BEAM-12320
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-875776666


   I'm running the post commits one more time to confirm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] aromanenko-dev commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874952704


   Ok, thanks! Please, let me know if that PR is a real cause. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-873254632


   Run SQL PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-875773001


   Run SQL PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] tysonjh closed pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
tysonjh closed pull request #15122:
URL: https://github.com/apache/beam/pull/15122


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] aromanenko-dev commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874133687


   @tysonjh Why #15049 should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] aromanenko-dev commented on pull request #15122: Revert "[BEAM-12456] Parallel querying in JdbcIO"

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #15122:
URL: https://github.com/apache/beam/pull/15122#issuecomment-874133687


   @tysonjh Why #15049 should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org