You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 04:12:36 UTC

[GitHub] [airflow] andormarkus opened a new pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

andormarkus opened a new pull request #16262:
URL: https://github.com/apache/airflow/pull/16262


   Keda supports minReplicaCount (default value is 0). It would be great if the users would have the option in the helm chart to overwrite the default value.
   
   
   closes: #16256
   
   @mik-laj Please can you review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-854343880

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-855310443


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-854343880

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

kaxil closed pull request #16262:
URL: https://github.com/apache/airflow/pull/16262


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

kaxil commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-854972944


   (re-triggering CI to remove intermittent errors)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] andormarkus commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

andormarkus commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-855180709


   Rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

kaxil commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-855101685


   Can you rebase this PR on Master please, looks like it is more than 100 commits old


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #16262:
URL: https://github.com/apache/airflow/pull/16262#issuecomment-854972955


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #16262: feat: Helm chart adding minReplicaCount to the Keda

Posted by GitBox <gi...@apache.org>.

mik-laj merged pull request #16262:
URL: https://github.com/apache/airflow/pull/16262


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org