You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/11 09:34:46 UTC
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request, #1449: feat: support apisix v3 admin api
lingsamuel opened a new pull request, #1449:
URL: https://github.com/apache/apisix-ingress-controller/pull/1449
Signed-off-by: Ling Samuel <li...@gmail.com>
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [x] New feature provided
### What this PR does / why we need it:
Add flag `apisix-admin-api-version` to support APISIX 3.0 admin API.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] AlinsRan commented on pull request #1449: feat: support apisix v3 admin api
Posted by GitBox <gi...@apache.org>.
AlinsRan commented on PR #1449:
URL: https://github.com/apache/apisix-ingress-controller/pull/1449#issuecomment-1313152806
It is recommended to add a flag in the [config-default.yaml](https://github.com/apache/apisix-ingress-controller/blob/master/conf/config-default.yaml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1449: feat: support apisix v3 admin api
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1449:
URL: https://github.com/apache/apisix-ingress-controller/pull/1449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1449: [DRAFT] feat: support apisix v3 admin api
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1449:
URL: https://github.com/apache/apisix-ingress-controller/pull/1449#issuecomment-1313042067
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1449](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab8ca86) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/febeab4cac49dd97a6b257324ba9ba3b5396c514?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (febeab4) will **decrease** coverage by `0.06%`.
> The diff coverage is `47.95%`.
> :exclamation: Current head ab8ca86 differs from pull request most recent head 0c07a26. Consider uploading reports for the commit 0c07a26 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
- Coverage 41.30% 41.23% -0.07%
==========================================
Files 82 82
Lines 7271 7310 +39
==========================================
+ Hits 3003 3014 +11
- Misses 3921 3944 +23
- Partials 347 352 +5
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/api/validation/utils.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS92YWxpZGF0aW9uL3V0aWxzLmdv) | `32.43% <0.00%> (ø)` | |
| [pkg/apisix/plugin\_metadata.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5fbWV0YWRhdGEuZ28=) | `4.39% <0.00%> (ø)` | |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `56.79% <ø> (ø)` | |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `64.13% <ø> (ø)` | |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `36.39% <35.00%> (-1.66%)` | :arrow_down: |
| [pkg/apisix/consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jb25zdW1lci5nbw==) | `36.30% <50.00%> (ø)` | |
| [pkg/apisix/global\_rule.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9nbG9iYWxfcnVsZS5nbw==) | `36.05% <50.00%> (ø)` | |
| [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `36.91% <50.00%> (ø)` | |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `38.51% <50.00%> (ø)` | |
| [pkg/apisix/stream\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zdHJlYW1fcm91dGUuZ28=) | `36.42% <50.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1449/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1449: feat: support apisix v3 admin api
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1449:
URL: https://github.com/apache/apisix-ingress-controller/pull/1449#discussion_r1021117640
##########
.github/workflows/e2e-test-ci-v2-cron.yml:
##########
@@ -0,0 +1,190 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+name: e2e-test-ci
+
+on:
+ schedule: '0 0 * * *'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ changes:
+ runs-on: ubuntu-latest
+ outputs:
+ docs: ${{ steps.filter.outputs.docs }}
+ go: ${{ steps.filter.outputs.go }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ submodules: recursive
+
+ - uses: ./.github/actions/paths-filter
+ id: filter
+ with:
+ token: ${{ secrets.GITHUB_TOKEN }}
+ filters: |
+ docs:
+ - 'docs/**/*'
+ - '*.md'
+ go:
+ - '*.go'
+ - '**/*.go'
+ - 'go.mod'
+ - 'go.sum'
+ - 'Makefile'
+ - 'Dockerfile'
+ - 'test/e2e/**/*'
+ - 'conf/**'
+ - 'utils/**'
+ build:
+ name: Build
+ runs-on: ubuntu-latest
+ needs: changes
+ if: needs.changes.outputs.go == 'true'
+
+ steps:
+
+ - name: Checkout
+ uses: actions/checkout@v3 # v3.0.2
+
+ - name: Setup Go Env
+ id: go
+ uses: actions/setup-go@v3 # v3.2.0
+ with:
+ go-version: '1.19'
+
+ - name: Set up QEMU
+ uses: docker/setup-qemu-action@v2 #v2.0.0
+
+ - name: Set up Docker Buildx
+ id: buildx
+ uses: docker/setup-buildx-action@v2 # v2.0.0
+ with:
+ version: latest
+
+ - name: Prepare Host
+ run: |
+ curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.11.1/kind-linux-amd64
+ chmod +x ./kind
+ sudo mv kind /usr/local/bin
+
+ - name: Build images
+ env:
+ TAG: dev
+ ARCH: amd64
+ REGISTRY: localhost:5000
+ ENABLE_PROXY: "false"
+ run: |
+ echo "building images..."
+ make clean-image build-images
+
+ echo "creating images cache..."
+ docker save \
+ localhost:5000/apache/apisix:dev \
+ localhost:5000/bitnami/etcd:dev \
+ localhost:5000/apache/apisix-ingress-controller:dev \
+ localhost:5000/kennethreitz/httpbin:dev \
+ localhost:5000/test-backend:dev \
+ localhost:5000/jmalloc/echo-server:dev \
+ localhost:5000/busybox:dev \
+ | pigz > docker.tar.gz
+
+ - name: cache
+ uses: actions/upload-artifact@v3 # v3.1.0
+ with:
+ name: docker.tar.gz
+ path: docker.tar.gz
Review Comment:
I think this will conflict with the v3 version of the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org