[GitHub] [geode] kirklund commented on pull request #2978: GEODE-6143: Import methods from Mockito instead of PowerMockito

["kirklund (GitHub)" <gi...@apache.org>]

I'm just following JUnit convention. You'll find that none of the books, articles or examples mark the rules as `final`. It's ok for it to be `final` but I strive for my code to look as much like the books, articles and examples so as not to slow down someone who is reading the code or is looking at the code as an example. Put final rules in one test and you'll see developers start to spread that to other tests. Again, it's not that it's not ok, it's just that if we want to follow the best practices and coding conventions that are put forth in books, articles and other examples, then we should not put `final` on JUnit rules.

[ Full content available at: https://github.com/apache/geode/pull/2978 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org