[jira] [Commented] (HADOOP-10752) Add support for hardware crc on ARM aarch64 architecture

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354407#comment-14354407 ] 

Hadoop QA commented on HADOOP-10752:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12652581/jira-10752.patch
  against trunk revision 7711049.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5905//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5905//console

This message is automatically generated.

> Add support for hardware crc on ARM aarch64 architecture
> --------------------------------------------------------
>
>                 Key: HADOOP-10752
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10752
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native, performance
>    Affects Versions: trunk-win
>         Environment: ARM aarch64 Juno development platform
>            Reporter: Edward Nevill
>            Priority: Minor
>              Labels: performance
>         Attachments: jira-10752.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This patch adds support for hardware crc for ARM's new 64 bit architecture.
> The patch is completely conditionalized on __arch64__
> For the moment I have only done the non pipelined version as the hw I have only has 1 crc execute unit.
> Some initial benchmarks on terasort give
> sw crc: 107 sec
> hw crc: 103 sec
> The performance improvement is quite small, but this is limited by the fact that I am using early stage hw which is not performant.
> I have also built it on x86 and I think the change is fairly safe for other architectures because post conditionalization the src is identical on other architectures.
> This is the first patch I have submitted for Hadoop so I would welcome any feedback and help.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)