[jira] [Commented] (SOLR-12648) Autoscaling framework based replica placement is not used unless a policy is specified or non-empty cluster policy exists

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636748#comment-16636748 ] 

Shalin Shekhar Mangar commented on SOLR-12648:
----------------------------------------------

Patch passes all tests and precommit.

It also fixes a bug where implicitly added cluster preferences were being persisted in ZK when we added the scheduled and auto add replicas trigger. Now we use the empty flag to decide whether to write the cluster preferences and policy in the MapWriter implementation. I added a test for this new behavior in TestPolicy.

> Autoscaling framework based replica placement is not used unless a policy is specified or non-empty cluster policy exists
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12648
>                 URL: https://issues.apache.org/jira/browse/SOLR-12648
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling, SolrCloud
>    Affects Versions: 7.4
>            Reporter: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: 7.6, master (8.0)
>
>         Attachments: SOLR-12648.patch, SOLR-12648.patch, SOLR-12648.patch, SOLR-12648.patch
>
>
> Assign.java has a piece of code to decide which placement framework to use (we have three today):
> {code}
> if (rulesMap == null && policyName == null && autoScalingConfig.getPolicy().getClusterPolicy().isEmpty())
> {code}
> Note that the presence of cluster preferences is not a criteria. So even if a user adds cluster preferences, they will not be respected unless a policy also exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org