You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/08/12 15:01:02 UTC
Review Request 37393: Hive alert on secure cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Bugs: AMBARI-12740
https://issues.apache.org/jira/browse/AMBARI-12740
Repository: ambari
Description
-------
Steps:
Deploy cluster with Hive.
Enable Security.
Result: Hive service has critical aler
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
Diff: https://reviews.apache.org/r/37393/diff/
Testing
-------
Unit tests passed!
Thanks,
Artem Baranchuk
Re: Review Request 37393: Hive alert on secure cluster
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Авг. 12, 2015, 1:43 п.п., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py, lines 212-213
> > <https://reviews.apache.org/r/37393/diff/1/?file=1038380#file1038380line212>
> >
> > Would it be possible to use `curl_krb_request` here? It handles this type of scenario well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51
curl_krb_request method has some problem. Think we need use silent mode for curl usinh -sL. But it is ok for now!
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/#review95084
-----------------------------------------------------------
On Авг. 12, 2015, 1:01 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37393/
> -----------------------------------------------------------
>
> (Updated Авг. 12, 2015, 1:01 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-12740
> https://issues.apache.org/jira/browse/AMBARI-12740
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
>
> Deploy cluster with Hive.
> Enable Security.
>
> Result: Hive service has critical aler
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
>
> Diff: https://reviews.apache.org/r/37393/diff/
>
>
> Testing
> -------
>
> Unit tests passed!
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 37393: Hive alert on secure cluster
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Авг. 12, 2015, 1:43 п.п., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py, lines 212-213
> > <https://reviews.apache.org/r/37393/diff/1/?file=1038380#file1038380line212>
> >
> > Would it be possible to use `curl_krb_request` here? It handles this type of scenario well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51
>
> Artem Baranchuk wrote:
> curl_krb_request method has some problem. Think we need use silent mode for curl usinh -sL. But it is ok for now!
I will create separate jira to investigate it. Currently there is no way to check stderror because even if command status 200 stderror contains output when return_only_http_code is True.
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/#review95084
-----------------------------------------------------------
On Авг. 12, 2015, 5:37 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37393/
> -----------------------------------------------------------
>
> (Updated Авг. 12, 2015, 5:37 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-12740
> https://issues.apache.org/jira/browse/AMBARI-12740
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
>
> Deploy cluster with Hive.
> Enable Security.
>
> Result: Hive service has critical aler
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
>
> Diff: https://reviews.apache.org/r/37393/diff/
>
>
> Testing
> -------
>
> Unit tests passed!
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 37393: Hive alert on secure cluster
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/#review95084
-----------------------------------------------------------
Ship it!
Ship It!
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py (line 174)
<https://reviews.apache.org/r/37393/#comment149901>
This should be unnecessary since the absolute path to `kinit` is determined in `get_kinit_path`. But I don't think it is hurting anything.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py (lines 178 - 179)
<https://reviews.apache.org/r/37393/#comment149903>
Would it be possible to use `curl_krb_request` here? It handles this type of scenario well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py (lines 199 - 200)
<https://reviews.apache.org/r/37393/#comment149904>
Would it be possible to use `curl_krb_request` here? It handles this type of scenario well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51
- Robert Levas
On Aug. 12, 2015, 9:01 a.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37393/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 9:01 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-12740
> https://issues.apache.org/jira/browse/AMBARI-12740
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
>
> Deploy cluster with Hive.
> Enable Security.
>
> Result: Hive service has critical aler
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
>
> Diff: https://reviews.apache.org/r/37393/diff/
>
>
> Testing
> -------
>
> Unit tests passed!
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 37393: Hive alert on secure cluster
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/#review95080
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Авг. 12, 2015, 1:01 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37393/
> -----------------------------------------------------------
>
> (Updated Авг. 12, 2015, 1:01 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
>
>
> Bugs: AMBARI-12740
> https://issues.apache.org/jira/browse/AMBARI-12740
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
>
> Deploy cluster with Hive.
> Enable Security.
>
> Result: Hive service has critical aler
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
>
> Diff: https://reviews.apache.org/r/37393/diff/
>
>
> Testing
> -------
>
> Unit tests passed!
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 37393: Hive alert on secure cluster
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/
-----------------------------------------------------------
(Updated Авг. 12, 2015, 5:37 п.п.)
Review request for Ambari, Andrew Onischuk and Dmytro Sen.
Bugs: AMBARI-12740
https://issues.apache.org/jira/browse/AMBARI-12740
Repository: ambari
Description
-------
Steps:
Deploy cluster with Hive.
Enable Security.
Result: Hive service has critical aler
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py 3d0e14c
Diff: https://reviews.apache.org/r/37393/diff/
Testing
-------
Unit tests passed!
Thanks,
Artem Baranchuk