You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/02 23:59:24 UTC
[kudu-CR] docs: update guidance for binding functions
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12146
Change subject: docs: update guidance for binding functions
......................................................................
docs: update guidance for binding functions
Tweaked the docs to call out equivalent STL functions and their
relationship with std::shared_ptr.
A rendered version can be found here:
https://github.com/andrwng/kudu/blob/docs_cbs/docs/contributing.adoc#function-binding-and-callbacks
Change-Id: I326931a096b7184d403aea116248cffcde5c9775
---
M docs/contributing.adoc
1 file changed, 21 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/12146/1
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] docs: update guidance for binding functions
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12146
to look at the new patch set (#2).
Change subject: docs: update guidance for binding functions
......................................................................
docs: update guidance for binding functions
Tweaked the docs to call out equivalent STL functions and their
relationship with std::shared_ptr.
A rendered version can be found here:
https://github.com/andrwng/kudu/blob/docs_cbs/docs/contributing.adoc#function-binding-and-callbacks
Change-Id: I326931a096b7184d403aea116248cffcde5c9775
---
M docs/contributing.adoc
1 file changed, 21 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/12146/2
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: update guidance for binding functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc
File docs/contributing.adoc:
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@301
PS1, Line 301: `bind` and `function`
nit: `std::bind` and `std::function`, otherwise it's a bit confusing because of the prior discussion of boost::bind and boost::function in the paragraph above.
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@306
PS1, Line 306: place holders
placeholders ?
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 00:27:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update guidance for binding functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc
File docs/contributing.adoc:
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@312
PS1, Line 312: Callback goes out of scope
nit: the counterpart about std::function has the name of the class with grave accents, maybe add them here as well.
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 00:32:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update guidance for binding functions
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc
File docs/contributing.adoc:
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@301
PS1, Line 301: `std::bind` and `std:
> nit: `std::bind` and `std::function`, otherwise it's a bit confusing becaus
Done
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@306
PS1, Line 306: placeholders,
> placeholders ?
Done
http://gerrit.cloudera.org:8080/#/c/12146/1/docs/contributing.adoc@312
PS1, Line 312: he `Callback` goes out of
> nit: the counterpart about std::function has the name of the class with gra
Done
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 00:44:31 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update guidance for binding functions
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
docs: update guidance for binding functions
Tweaked the docs to call out equivalent STL functions and their
relationship with std::shared_ptr.
A rendered version can be found here:
https://github.com/andrwng/kudu/blob/docs_cbs/docs/contributing.adoc#function-binding-and-callbacks
Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Reviewed-on: http://gerrit.cloudera.org:8080/12146
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/contributing.adoc
1 file changed, 21 insertions(+), 9 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] docs: update guidance for binding functions
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 01:06:38 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update guidance for binding functions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 )
Change subject: docs: update guidance for binding functions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I326931a096b7184d403aea116248cffcde5c9775
Gerrit-Change-Number: 12146
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 00:23:07 +0000
Gerrit-HasComments: No