You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/24 20:02:40 UTC

[GitHub] [tvm] tqchen opened a new pull request #7521: [PYTHON] Enable proper error message in python package

tqchen opened a new pull request #7521:
URL: https://github.com/apache/tvm/pull/7521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7521: [PYTHON] Enable proper error message in python package

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7521:
URL: https://github.com/apache/tvm/pull/7521#issuecomment-785337310


   cc @tkonolige @junrushao1994 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige commented on pull request #7521: [PYTHON] Enable proper error message in python package

Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #7521:
URL: https://github.com/apache/tvm/pull/7521#issuecomment-785344167


   Where is the error message for when the user is using python 2? It seems like that check should be in this file before any imports are loaded.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen merged pull request #7521: [PYTHON] Enable proper error message in python package

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7521:
URL: https://github.com/apache/tvm/pull/7521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen edited a comment on pull request #7521: [PYTHON] Enable proper error message in python package

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7521:
URL: https://github.com/apache/tvm/pull/7521#issuecomment-785344596


   The error check is in _ffi._pyversion, which should be fired in the first import. Verified in my local setups


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7521: [PYTHON] Enable proper error message in python package

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7521:
URL: https://github.com/apache/tvm/pull/7521#issuecomment-785344596


   The error check is in _ffi._py2, which should be fired in the first import. Verified in my local setups


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org