You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by zh...@apache.org on 2022/08/03 11:57:36 UTC

[dolphinscheduler] 16/16: fix: Current node settings number of failed retries may not be negative (#10530)

This is an automated email from the ASF dual-hosted git repository.

zhongjiajie pushed a commit to branch 3.0.0-prepare
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git

commit 9740a6e42f4a086ab29e08fb4f366332cc15fc04
Author: xuhhui <xu...@cmss.chinamobile.com>
AuthorDate: Wed Jun 22 18:22:33 2022 +0800

    fix: Current node settings number of failed retries may not be negative (#10530)
    
    (cherry picked from commit 198e00db5819f55c9db3a4e1af542a3bf53b47c8)
---
 .../views/projects/task/components/node/fields/use-delay-time.ts    | 3 +++
 .../src/views/projects/task/components/node/fields/use-failed.ts    | 6 ++++++
 .../src/views/projects/task/components/node/fields/use-flink.ts     | 3 ++-
 .../src/views/projects/task/components/node/fields/use-sqoop.ts     | 3 ++-
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-delay-time.ts b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-delay-time.ts
index 7e747d6e5f..12a6702362 100644
--- a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-delay-time.ts
+++ b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-delay-time.ts
@@ -25,6 +25,9 @@ export function useDelayTime(model: { [field: string]: any }): IJsonItem {
     field: 'delayTime',
     name: t('project.node.delay_execution_time'),
     span: 12,
+    props: {
+      min: 0
+    },
     slots: {
       suffix: () => t('project.node.minute')
     },
diff --git a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-failed.ts b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-failed.ts
index 33b0adc911..f511c8e455 100644
--- a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-failed.ts
+++ b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-failed.ts
@@ -26,6 +26,9 @@ export function useFailed(): IJsonItem[] {
       field: 'failRetryTimes',
       name: t('project.node.number_of_failed_retries'),
       span: 12,
+      props: {
+        min: 0
+      },
       slots: {
         suffix: () => t('project.node.times')
       }
@@ -35,6 +38,9 @@ export function useFailed(): IJsonItem[] {
       field: 'failRetryInterval',
       name: t('project.node.failed_retry_interval'),
       span: 12,
+      props: {
+        min: 0
+      },
       slots: {
         suffix: () => t('project.node.minute')
       }
diff --git a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-flink.ts b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-flink.ts
index ac8f4f0850..568d126ea2 100644
--- a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-flink.ts
+++ b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-flink.ts
@@ -191,7 +191,8 @@ export function useFlink(model: { [field: string]: any }): IJsonItem[] {
       name: t('project.node.task_manager_number'),
       span: taskManagerNumberSpan,
       props: {
-        placeholder: t('project.node.task_manager_number_tips')
+        placeholder: t('project.node.task_manager_number_tips'),
+        min: 1
       },
       value: model.taskManager
     },
diff --git a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sqoop.ts b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sqoop.ts
index 44125bf22a..cb95fe40a0 100644
--- a/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sqoop.ts
+++ b/dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-sqoop.ts
@@ -77,7 +77,8 @@ export function useSqoop(model: { [field: string]: any }): IJsonItem[] {
       name: t('project.node.concurrency'),
       span: unCustomSpan,
       props: {
-        placeholder: t('project.node.concurrency_tips')
+        placeholder: t('project.node.concurrency_tips'),
+        min: 1
       }
     },
     {