You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2021/05/28 15:35:46 UTC

[james-mime4j] 06/07: [WARNING] Group: iterations can be replaces by Collection::addAll

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git

commit f86273ef1d960dde553f9be205721a9e0cde1446
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:46:13 2021 +0700

    [WARNING] Group: iterations can be replaces by Collection::addAll
    
    This is likely to be more efficient.
---
 dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java b/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
index 14b1433..1da7939 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
@@ -86,9 +86,7 @@ public class Group extends Address {
 
     @Override
     protected void doAddMailboxesTo(List<Mailbox> results) {
-        for (Mailbox mailbox : mailboxList) {
-            results.add(mailbox);
-        }
+        results.addAll(mailboxList);
     }
 
     @Override

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org