[GitHub] [tvm] mdw-octoml commented on pull request #7766: Rename references to 0.0.0.0 to localhost.

[GitBox <gi...@apache.org>]

mdw-octoml commented on pull request #7766:
URL: https://github.com/apache/tvm/pull/7766#issuecomment-810310142


   So, I'm a little confused here. It seems that this PR is changing the default both for the address the server binds to as well as the address a client would connect to. Am I getting that right?
   
   My understanding is that on both Windows and Linux, binding a server to 0.0.0.0 is the correct thing to do, since it allows the server to listen on any address / any interface, which is necessary in order to accept external connections. Binding to localhost or 127.0.0.1 would only bind on the loopback interface (on Linux, anyway) only permitting local connection, but I don't think that is the correct default behavior.
   
   The client address should, of course, be specified explicitly, either as 127.0.0.1 (or, equivalently, 'localhost') or explicitly when connecting to a remote address. So changing the client default to localhost seems fine, but I would not change the server default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org