[Bug 53750] New: TestCompiler saves unnecessary entries in pairing collection

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53750

          Priority: P2
            Bug ID: 53750
          Assignee: issues@jmeter.apache.org
           Summary: TestCompiler saves unnecessary entries in pairing
                    collection
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: sebb@apache.org
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Main
           Product: JMeter

The TestCompiler pairing collection is only used to decide whether to call the
method ObjectPair.addTestElements().

Now that method contains the following code:

public void addTestElements() {
    if (parent instanceof Controller && (child instanceof Sampler || child
instanceof Controller)) {
        parent.addTestElement(child);
    }
}

i.e. for some combinations of child and parent, it does nothing. There is
therefore no reason even to store such entries in the pairing set; such entries
just waste space.

The fix is to check the condition before checking the pairing set.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53750] TestCompiler saves unnecessary entries in pairing collection

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53750

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/viewvc?rev=1375362&view=rev
Log:
TestCompiler saves unnecessary entries in pairing collection
Bugzilla Id: 53750

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.