[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12106: [Feature-11488][Datax]Datax can submit to YARN

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #12106:
URL: https://github.com/apache/dolphinscheduler/pull/12106#discussion_r979266781


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -419,6 +438,58 @@ private String buildShellCommandFile(String jobConfigFilePath, Map<String, Prope
         return fileName;
     }
 
+    private String buildYarnShellCommandFile(String jobConfigFilePath, Map<String, Property> paramsMap, String dataxHdfsPath, String dataxOnYarnDependJar)

Review Comment:
   Since the execution of many DS task plugins is based on `ShellExecutor`, would u like to improve it so that those tasks could also run shell command in yarn containers? BTW, in this PR, it seems `datax-on-yarn-1.0.0.jar` is built from code in an individual repo and this might not be a good practice. https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/ShellCommandExecutor.java



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -94,6 +94,17 @@ public class DataxTask extends AbstractTaskExecutor {
      * datax path
      */
     private static final String DATAX_PATH = "${DATAX_HOME}/bin/datax.py";
+
+    /**
+     * datax hdfs path
+     */
+    private static final String DATAX_HDFS_PATH = "DATAX_HDFS_PATH";
+
+    /**
+     * datax hdfs path
+     */
+    private static final String DATAX_ON_YARN_DEPEND_JAR = "DATAX_ON_YARN_DEPEND_JAR";

Review Comment:
   May I ask whether we have an option for users to choose to submit a `DataX` task to yarn or not in UI? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org