You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "chaokunyang (via GitHub)" <gi...@apache.org> on 2026/04/13 07:05:35 UTC

[I] [Dart] Performance Optimization [fory]

chaokunyang opened a new issue, #3558:
URL: https://github.com/apache/fory/issues/3558

   ### Feature Request
   
   _No response_
   
   ### Is your feature request related to a problem? Please describe
   
   This is fory benchmarkk result in https://github.com/apache/fory/pull/3551
   <img width="4200" height="900" alt="Image" src="https://github.com/user-attachments/assets/25c22fb3-45bc-48dc-9629-955644ed0fe3" />
   
   Fory struct is not fast for struct. 
   
   Fory binary protocol is more efficient than protobuf, fory don't need to write tag-based kv data, but in the benchmark result here, fory is not fast enough. There must be more performance gains to squeze
   
   ### Describe the solution you'd like
   
   Take Java generated Serializer code for struct as reference, update fory dart codegen to generate mpre efficient serializer code
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang closed issue #3558: [Dart] Performance Optimization
URL: https://github.com/apache/fory/issues/3558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "yash-agarwa-l (via GitHub)" <gi...@apache.org>.
yash-agarwa-l commented on issue #3558:
URL: https://github.com/apache/fory/issues/3558#issuecomment-4234491144

   Yes I am, Thank you so much! I'll look into this in detail shortly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #3558:
URL: https://github.com/apache/fory/issues/3558#issuecomment-4234499398

   Great! I will merge #3551 later today, you can start from new main commit after the pr is merged. And create a pr to optimzie fory struct deserialize first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #3558:
URL: https://github.com/apache/fory/issues/3558#issuecomment-4234466875

   @yash-agarwa-l are you interested in this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #3558:
URL: https://github.com/apache/fory/issues/3558#issuecomment-4242365958

   It's fine, you don't have to make a separate pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [I] [Dart] Performance Optimization [fory]

Posted by "yash-agarwa-l (via GitHub)" <gi...@apache.org>.
yash-agarwa-l commented on issue #3558:
URL: https://github.com/apache/fory/issues/3558#issuecomment-4241944350

   Hi, I am sorry for the delay, Just a quick question before I open the PR;`benchmarks/dart/lib/src/workloads.dart` on main calls `Fory(config: const Config(compatible: true))` after the refactor(dart) PR, but PR #3560 refactored the Fory constructor which donot contain config parameter now, and it donot compile. I think i should fix this line to `Fory(compatible: true)` in my perf PR (matches what #3560 did to the test files). Is that fine, or shall i make a separate cleanup PR first? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org