You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/24 17:55:00 UTC

[jira] [Work logged] (BEAM-14157) Don't send requests on a closed windmill Grpc streams

     [ https://issues.apache.org/jira/browse/BEAM-14157?focusedWorklogId=747348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747348 ]

ASF GitHub Bot logged work on BEAM-14157:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Mar/22 17:54
            Start Date: 24/Mar/22 17:54
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit merged pull request #17162:
URL: https://github.com/apache/beam/pull/17162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 747348)
    Time Spent: 2h  (was: 1h 50m)

> Don't send requests on a closed windmill Grpc streams
> -----------------------------------------------------
>
>                 Key: BEAM-14157
>                 URL: https://issues.apache.org/jira/browse/BEAM-14157
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Arun Pandian
>            Priority: P2
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> GrpcWindmillServer could send requests requests on client closed streams. This leads to windmill streams getting stalling occasionally for few seconds to few minutes. grpc-java doc says not to call onNext to send after a stream is client closed. 
> When the streams get stalled it is logged as "Output channel stalled for {}s, outbound thread {}."  from [here|https://github.com/apache/beam/blob/7727dc99ed5dc1fb46166ef496ab3607ee2779f8/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/DirectStreamObserver.java#L100]
> Ref:
> [https://github.com/grpc/grpc-java/blob/master/stub/src/main/java/io/grpc/stub/StreamObserver.java#L62]
> [https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java#L939]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)