You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by simon <sk...@apache.org> on 2007/08/10 22:37:10 UTC

[orchestra] static log objects

Hi Mario et al.,

I've noticed that a number of Orchestra classes use
  private static final Log log = ....;
See class ConversationManager for an example.

I don't think static log objects are a good idea in libraries, as
described here:
  http://wiki.apache.org/jakarta-commons/Logging/StaticLog

Would it be ok by you to remove the "static" keyword from all Log object
references?

Regards,

Simon

Re: [orchestra] static log objects

Posted by Mario Ivankovits <ma...@ops.co.at>.

Hi!
> I've noticed that a number of Orchestra classes use
>   private static final Log log = ....;
> See class ConversationManager for an example.
>
> I don't think static log objects are a good idea in libraries, as
> described here:
>   http://wiki.apache.org/jakarta-commons/Logging/StaticLog
>   
Yepp, I know. I just did it that way to hear/read your words about this
topic again :-D ... Sorry, couldn't resist ;-)
So, yes, please change it the way it should be. Maybe this could be a
template for tomahawk/myfaces too ... later.

Ciao,
Mario