[GitHub] [calcite] laurentgo commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

[GitBox <gi...@apache.org>]

laurentgo commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r301706499
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
 ##########
 @@ -303,6 +303,10 @@ public RelNode createAggregate(RelNode input,
   public interface FilterFactory {
     /** Creates a filter. */
     RelNode createFilter(RelNode input, RexNode condition);
+
+    /** Creates a filter. */
+    RelNode createFilter(RelNode input, RexNode condition,
 
 Review comment:
   I agree that a default method would be nice, but wouldn't that be misleading/causing runtime bugs in implementations as correlation id would not be populated anymore when using relfieldtrimmer, as the value is ignored?
   
   Is it slightly better to check that the list is actually empty? (still a runtime exception but at least cause is clearly identified...)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services