[jira] [Created] (SLIDER-1217) Coverity scan issue identified with SLIDER-1214's commit

["Gour Saha (JIRA)" <ji...@apache.org>]

Gour Saha created SLIDER-1217:
---------------------------------

             Summary: Coverity scan issue identified with SLIDER-1214's commit
                 Key: SLIDER-1217
                 URL: https://issues.apache.org/jira/browse/SLIDER-1217
             Project: Slider
          Issue Type: Sub-task
            Reporter: Gour Saha


Coverity scan identified the following defect which was added as part of SLIDER-1214's commit -

{noformat}
*** CID 142179:  Concurrent data access violations  (GUARDED_BY_VIOLATION)
/slider-core/src/main/java/org/apache/slider/server/appmaster/state/AppState.java: 2621 in org.apache.slider.server.appmaster.state.AppState.storeContainerDiagnostics(java.lang.String, int, java.lang.String, int, java.lang.String, long)()
2615           containerInfo.exitCode = exitCode;
2616           if (StringUtils.isNotBlank(diagnostics)) {
2617             containerInfo.diagnostics = diagnostics;
2618           }
2619           containerInfo.state = state;
2620           if (logLink != null) {
     CID 142179:  Concurrent data access violations  (GUARDED_BY_VIOLATION)
     Accessing "containerInfo.logServerLogLink" without holding lock "AppState.this". Elsewhere, "org.apache.slider.api.types.ContainerInformation.logServerLogLink" is accessed with "AppState.this" held 2 out of 3 times.
2621             containerInfo.logServerLogLink = logLink;
2622           }
2623           containerInfo.completionTime = completionTime;
2624         }
2625       }
2626    
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)