You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/25 00:33:45 UTC

[GitHub] [beam] y1chi opened a new pull request, #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

y1chi opened a new pull request, #22861:
URL: https://github.com/apache/beam/pull/22861

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] TheNeuralBit commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1227625624

   Run Java Dataflow V2 ValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] TheNeuralBit commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1233324012

   @y1chi do you know what's going wrong here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1227489057

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1228696863

   Run Java Dataflow V2 ValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1234544375

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1226634832

   Run Java Dataflow V2 ValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1227502390

   R: @TheNeuralBit @kennknowles 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] TheNeuralBit commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1227506366

   It looks like the unskipped test still wasn't run? 
   ![image](https://user-images.githubusercontent.com/675055/186720802-e8e00667-abed-439f-9aa1-e2efacf9877f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1227612480

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1233367510

   Run Java Dataflow V2 ValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi merged pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi merged PR #22861:
URL: https://github.com/apache/beam/pull/22861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1233365852

   It looks like TestStream is not allowed in dataflow prod. I'd still remove the test from the list since it is redundant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] TheNeuralBit commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1233416022

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] y1chi commented on pull request #22861: Unsickbay testEventTimeTimerSetWithinAllowedLateness test

Posted by GitBox <gi...@apache.org>.
y1chi commented on PR #22861:
URL: https://github.com/apache/beam/pull/22861#issuecomment-1234544502

   Run Java Dataflow V2 ValidatesRunner Streaming


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org