You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Podkowinski (JIRA)" <ji...@apache.org> on 2017/11/20 12:52:00 UTC
[jira] [Commented] (CASSANDRA-13175) Integrate "Error Prone" Code
Analyzer
[ https://issues.apache.org/jira/browse/CASSANDRA-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259203#comment-16259203 ]
Stefan Podkowinski commented on CASSANDRA-13175:
------------------------------------------------
For the record, I just rebased and checked the errorprone target of my wip branch again, but this time with the latest guava version that we now have in trunk. Now I'm getting a new error regarding the putBytes method in the guava Hasher used by the Validator. This method has been added in 23 and cannot be found with the guava version used by errorprone. I'd therefor suggest to wait until [#492|https://github.com/google/error-prone/issues/492] has been addressed by the errorprone project
> Integrate "Error Prone" Code Analyzer
> -------------------------------------
>
> Key: CASSANDRA-13175
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13175
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stefan Podkowinski
> Assignee: Stefan Podkowinski
> Attachments: 0001-Add-Error-Prone-code-analyzer.patch, checks-2_2.out, checks-3_0.out, checks-trunk.out
>
>
> I've been playing with [Error Prone|http://errorprone.info/] by integrating it into the build process and to see what kind of warnings it would produce. So far I'm positively impressed by the coverage and usefulness of some of the implemented checks. See attachments for results.
> Unfortunately there are still some issues on how the analyzer is effecting generated code and used guava versions, see [#492|https://github.com/google/error-prone/issues/492]. In case those issues have been solved and the resulting code isn't affected by the analyzer, I'd suggest to add it to trunk with warn only behaviour and some less useful checks disabled. Alternatively a new ant target could be added, maybe with build breaking checks and CI integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org