You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/07/07 18:33:45 UTC
[superset] branch master updated: fix: Wrong positioning of filter tooltips on scroll (#24617)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new c53b249998 fix: Wrong positioning of filter tooltips on scroll (#24617)
c53b249998 is described below
commit c53b2499988b5aeec96b1064f86703a3891e0efc
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Fri Jul 7 15:33:39 2023 -0300
fix: Wrong positioning of filter tooltips on scroll (#24617)
---
.../nativeFilters/FilterBar/FilterControls/FilterControl.tsx | 1 +
.../controls/DateFilterControl/DateFilterLabel.tsx | 12 ++++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
index b7f2ba04f2..2d8af510dc 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx
@@ -204,6 +204,7 @@ const DescriptionToolTip = ({ description }: { description: string }) => (
WebkitBoxOrient: 'vertical',
textOverflow: 'ellipsis',
}}
+ getPopupContainer={trigger => trigger.parentElement as HTMLElement}
>
<i
className="fa fa-info-circle text-muted"
diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
index a3d44eb570..d19a423814 100644
--- a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
+++ b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
@@ -365,7 +365,11 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
}
destroyTooltipOnHide
>
- <Tooltip placement="top" title={tooltipTitle}>
+ <Tooltip
+ placement="top"
+ title={tooltipTitle}
+ getPopupContainer={trigger => trigger.parentElement as HTMLElement}
+ >
<DateLabel
label={actualTimeRange}
isActive={show}
@@ -379,7 +383,11 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
const modalContent = (
<>
- <Tooltip placement="top" title={tooltipTitle}>
+ <Tooltip
+ placement="top"
+ title={tooltipTitle}
+ getPopupContainer={trigger => trigger.parentElement as HTMLElement}
+ >
<DateLabel
onClick={toggleOverlay}
label={actualTimeRange}