You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/08/31 07:15:10 UTC
[camel] branch main updated (77b02664c9a -> af598c4b384)
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
from 77b02664c9a (chores) camel-jms: avoid needlessly traversing the correlation ID array
new 28dca6c7a50 (chores) camel-jms: use unique resources in tests
new c0167ecd51d (chores) camel-jms: use final where possible
new 596db62b8bb (chores) camel-jms: use primitive types where possible
new af598c4b384 (chores) camel-jms: minor logging cleanups
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../camel/component/jms/BrowsableQueueTest.java | 4 +--
.../jms/FileRouteJmsKeepLastModifiedTest.java | 2 +-
.../component/jms/FileRouteJmsPreMoveTest.java | 2 +-
.../camel/component/jms/FileRouteToJmsTest.java | 2 +-
.../component/jms/FileRouteToJmsToFileTest.java | 2 +-
.../component/jms/JmsAsyncStartListenerTest.java | 2 +-
.../jms/JmsAsyncStartStopListenerTest.java | 2 +-
.../component/jms/JmsAsyncStopListenerTest.java | 2 +-
.../camel/component/jms/JmsClientAckTest.java | 2 +-
.../camel/component/jms/JmsComponentTest.java | 2 +-
.../jms/JmsCustomHeaderFilterStrategyTest.java | 2 +-
.../jms/JmsDefaultTaskExecutorTypeTest.java | 10 ++++----
.../component/jms/JmsDestinationResolverTest.java | 2 +-
.../component/jms/JmsInOutBeanReturnNullTest.java | 2 +-
.../jms/JmsInOutFixedReplyQueueTimeoutTest.java | 2 +-
.../jms/JmsInOutIndividualRequestTimeoutTest.java | 2 +-
.../JmsMessageCreatedStrategyComponentTest.java | 2 +-
.../jms/JmsMessageCreatedStrategyEndpointTest.java | 2 +-
.../component/jms/JmsMessageTimestampTest.java | 2 +-
.../component/jms/JmsNoRequestTimeoutTest.java | 2 +-
.../camel/component/jms/JmsQosRouteTest.java | 2 +-
...lyProcessRepliesConcurrentUsingThreadsTest.java | 2 +-
.../jms/JmsRequestReplyTemporaryCacheNoneTest.java | 7 ++---
.../component/jms/JmsRouteRequestReplyTest.java | 30 +++++++++++-----------
.../camel/component/jms/JmsRouteToFileTest.java | 2 +-
.../JmsRouteWithCustomListenerContainerTest.java | 2 +-
.../jms/JmsRouteWithInOnlyAndMultipleAcksTest.java | 2 +-
.../component/jms/JmsRouteWithInOnlyTest.java | 2 +-
.../camel/component/jms/JmsRoutingSlipTest.java | 2 +-
.../camel/component/jms/JmsSelectorOptionTest.java | 2 +-
.../apache/camel/component/jms/JmsSessionTest.java | 2 +-
.../camel/component/jms/JmsSimpleHeaderTest.java | 2 +-
.../component/jms/JmsSimpleInOnlyNoMutateTest.java | 2 +-
.../jms/JmsSimpleRequestCustomReplyToTest.java | 8 +++---
.../jms/JmsSimpleRequestLateReplyTest.java | 2 +-
.../component/jms/JmsSimpleRequestReply2Test.java | 2 +-
.../JmsSimpleRequestReplyFixedReplyQueueTest.java | 2 +-
.../component/jms/JmsSimpleRequestReplyTest.java | 2 +-
.../component/jms/PayloadByteArrayJmsTest.java | 2 +-
.../component/jms/SerializableRequestDto.java | 2 +-
.../component/jms/discovery/JmsDiscoveryTest.java | 2 +-
.../jms/issues/ActiveMQPropagateHeadersTest.java | 8 +++---
.../ActiveMQPropagateSerializableHeadersTest.java | 2 +-
.../issues/JmsBlockedAsyncRoutingEngineTest.java | 2 +-
...TransactionErrorHandlerRedeliveryDelayTest.java | 6 ++---
.../jms/temp/TemporaryQueueRouteTest.java | 2 +-
46 files changed, 76 insertions(+), 75 deletions(-)
[camel] 03/04: (chores) camel-jms: use primitive types where possible
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 596db62b8bb3715a549733967ed8b74209516ca6
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Aug 30 17:49:15 2022 +0200
(chores) camel-jms: use primitive types where possible
---
.../camel/component/jms/JmsDefaultTaskExecutorTypeTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
index ffe2e710c92..08fa7c40fdc 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
@@ -66,7 +66,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport {
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.threadPool", DefaultTaskExecutorType.ThreadPool);
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.threadPool", DefaultTaskExecutorType.ThreadPool);
assertMockEndpointsSatisfied();
- Long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
+ long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
LOG.info("Number of threads created, testThreadPoolTaskExecutor: {}", numberThreadsCreated);
assertTrue(numberThreadsCreated <= 100, "Number of threads created should be equal or lower than "
+ "100 with ThreadPoolTaskExecutor: " + numberThreadsCreated);
@@ -80,7 +80,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport {
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.simpleAsync", DefaultTaskExecutorType.SimpleAsync);
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.simpleAsync", DefaultTaskExecutorType.SimpleAsync);
assertMockEndpointsSatisfied(40, TimeUnit.SECONDS);
- Long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
+ long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
LOG.info("Number of threads created, testSimpleAsyncTaskExecutor: " + numberThreadsCreated);
assertTrue(numberThreadsCreated >= 800, "Number of threads created should be equal or higher than "
+ "800 with SimpleAsyncTaskExecutor: " + numberThreadsCreated);
@@ -94,7 +94,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport {
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.default", null);
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.default", null);
assertMockEndpointsSatisfied();
- Long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
+ long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
LOG.info("Number of threads created, testDefaultTaskExecutor: {}", numberThreadsCreated);
assertTrue(numberThreadsCreated >= 800, "Number of threads created should be equal or higher than "
+ "800 with default behaviour: " + numberThreadsCreated);
@@ -112,7 +112,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport {
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.default", DefaultTaskExecutorType.ThreadPool);
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.default", DefaultTaskExecutorType.ThreadPool);
assertMockEndpointsSatisfied(40, TimeUnit.SECONDS);
- Long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
+ long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
LOG.info("Number of threads created, testDefaultTaskExecutorThreadPoolAtComponentConfig: " + numberThreadsCreated);
assertTrue(numberThreadsCreated <= 100, "Number of threads created should be equal or lower than "
+ "100 with ThreadPoolTaskExecutor as a component default");
[camel] 04/04: (chores) camel-jms: minor logging cleanups
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit af598c4b384609cae630429c373fef2de9fc7ab9
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Aug 30 17:57:29 2022 +0200
(chores) camel-jms: minor logging cleanups
---
.../org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java | 2 +-
.../camel/component/jms/issues/JmsBlockedAsyncRoutingEngineTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
index 08fa7c40fdc..61d550952af 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
@@ -81,7 +81,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport {
doSendMessages("foo.JmsDefaultTaskExecutorTypeTest.simpleAsync", DefaultTaskExecutorType.SimpleAsync);
assertMockEndpointsSatisfied(40, TimeUnit.SECONDS);
long numberThreadsCreated = currentThreadCount() - beforeThreadCount;
- LOG.info("Number of threads created, testSimpleAsyncTaskExecutor: " + numberThreadsCreated);
+ LOG.info("Number of threads created, testSimpleAsyncTaskExecutor: {}", numberThreadsCreated);
assertTrue(numberThreadsCreated >= 800, "Number of threads created should be equal or higher than "
+ "800 with SimpleAsyncTaskExecutor: " + numberThreadsCreated);
}
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBlockedAsyncRoutingEngineTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBlockedAsyncRoutingEngineTest.java
index a6267d12efb..8ced6bc7dfb 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBlockedAsyncRoutingEngineTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBlockedAsyncRoutingEngineTest.java
@@ -147,7 +147,7 @@ public class JmsBlockedAsyncRoutingEngineTest extends CamelTestSupport {
@Override
public void send(ProducerBrokerExchange producerExchange, Message messageSend) throws Exception {
String destinationName = messageSend.getDestination().getPhysicalName();
- LOG.info("******** Received message for destination " + destinationName);
+ LOG.info("******** Received message for destination {}", destinationName);
// do not intercept sends to DLQ
if (destinationName.toLowerCase().contains("JmsBlockedAsyncRoutingEngineTest") && i == 0) {
[camel] 01/04: (chores) camel-jms: use unique resources in tests
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 28dca6c7a507c8090afe0a602affe65fd071e0c2
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Aug 30 17:29:17 2022 +0200
(chores) camel-jms: use unique resources in tests
---
.../camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java | 5 +++--
.../camel/component/jms/JmsSimpleRequestCustomReplyToTest.java | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
index 6e12eac01b4..d1c17d44c3c 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
@@ -44,9 +44,10 @@ public class JmsRequestReplyTemporaryCacheNoneTest extends AbstractJMSTest {
context.addRoutes(new RouteBuilder() {
@Override
public void configure() {
- from("direct:start").to("activemq:queue:hello?replyToCacheLevelName=CACHE_NONE");
+ from("direct:start")
+ .to("activemq:queue:JmsRequestReplyTemporaryCacheNoneTest?replyToCacheLevelName=CACHE_NONE");
- from("activemq:queue:hello").process(exchange -> {
+ from("activemq:queue:JmsRequestReplyTemporaryCacheNoneTest").process(exchange -> {
exchange.getIn().setBody("Bye World");
assertNotNull(exchange.getIn().getHeader("JMSReplyTo"));
}).to("mock:result");
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
index 605c4bd1e63..fe7c6532883 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
@@ -53,9 +53,9 @@ public class JmsSimpleRequestCustomReplyToTest extends AbstractJMSTest {
MockEndpoint result = getMockEndpoint("mock:result");
result.expectedMessageCount(1);
- Exchange out = template.request("activemq:queue:hello", exchange -> {
+ Exchange out = template.request("activemq:queue:JmsSimpleRequestCustomReplyToTest", exchange -> {
exchange.setPattern(ExchangePattern.InOnly);
- exchange.getIn().setHeader("MyReplyQeueue", "foo");
+ exchange.getIn().setHeader("MyReplyQeueue", "JmsSimpleRequestCustomReplyToTest.reply");
exchange.getIn().setBody("Hello World");
});
@@ -122,7 +122,7 @@ public class JmsSimpleRequestCustomReplyToTest extends AbstractJMSTest {
protected RouteBuilder createRouteBuilder() {
return new RouteBuilder() {
public void configure() {
- from(componentName + ":queue:hello").process(exchange -> {
+ from(componentName + ":queue:JmsSimpleRequestCustomReplyToTest").process(exchange -> {
assertEquals("Hello World", exchange.getIn().getBody());
myReplyTo = exchange.getIn().getHeader("MyReplyQeueue", String.class);
[camel] 02/04: (chores) camel-jms: use final where possible
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit c0167ecd51d0d7bdfcfc73e170037ad4c1ec94dc
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Aug 30 17:37:48 2022 +0200
(chores) camel-jms: use final where possible
---
.../camel/component/jms/BrowsableQueueTest.java | 4 +--
.../jms/FileRouteJmsKeepLastModifiedTest.java | 2 +-
.../component/jms/FileRouteJmsPreMoveTest.java | 2 +-
.../camel/component/jms/FileRouteToJmsTest.java | 2 +-
.../component/jms/FileRouteToJmsToFileTest.java | 2 +-
.../component/jms/JmsAsyncStartListenerTest.java | 2 +-
.../jms/JmsAsyncStartStopListenerTest.java | 2 +-
.../component/jms/JmsAsyncStopListenerTest.java | 2 +-
.../camel/component/jms/JmsClientAckTest.java | 2 +-
.../camel/component/jms/JmsComponentTest.java | 2 +-
.../jms/JmsCustomHeaderFilterStrategyTest.java | 2 +-
.../component/jms/JmsDestinationResolverTest.java | 2 +-
.../component/jms/JmsInOutBeanReturnNullTest.java | 2 +-
.../jms/JmsInOutFixedReplyQueueTimeoutTest.java | 2 +-
.../jms/JmsInOutIndividualRequestTimeoutTest.java | 2 +-
.../JmsMessageCreatedStrategyComponentTest.java | 2 +-
.../jms/JmsMessageCreatedStrategyEndpointTest.java | 2 +-
.../component/jms/JmsMessageTimestampTest.java | 2 +-
.../component/jms/JmsNoRequestTimeoutTest.java | 2 +-
.../camel/component/jms/JmsQosRouteTest.java | 2 +-
...lyProcessRepliesConcurrentUsingThreadsTest.java | 2 +-
.../jms/JmsRequestReplyTemporaryCacheNoneTest.java | 2 +-
.../component/jms/JmsRouteRequestReplyTest.java | 30 +++++++++++-----------
.../camel/component/jms/JmsRouteToFileTest.java | 2 +-
.../JmsRouteWithCustomListenerContainerTest.java | 2 +-
.../jms/JmsRouteWithInOnlyAndMultipleAcksTest.java | 2 +-
.../component/jms/JmsRouteWithInOnlyTest.java | 2 +-
.../camel/component/jms/JmsRoutingSlipTest.java | 2 +-
.../camel/component/jms/JmsSelectorOptionTest.java | 2 +-
.../apache/camel/component/jms/JmsSessionTest.java | 2 +-
.../camel/component/jms/JmsSimpleHeaderTest.java | 2 +-
.../component/jms/JmsSimpleInOnlyNoMutateTest.java | 2 +-
.../jms/JmsSimpleRequestCustomReplyToTest.java | 2 +-
.../jms/JmsSimpleRequestLateReplyTest.java | 2 +-
.../component/jms/JmsSimpleRequestReply2Test.java | 2 +-
.../JmsSimpleRequestReplyFixedReplyQueueTest.java | 2 +-
.../component/jms/JmsSimpleRequestReplyTest.java | 2 +-
.../component/jms/PayloadByteArrayJmsTest.java | 2 +-
.../component/jms/SerializableRequestDto.java | 2 +-
.../component/jms/discovery/JmsDiscoveryTest.java | 2 +-
.../jms/issues/ActiveMQPropagateHeadersTest.java | 8 +++---
.../ActiveMQPropagateSerializableHeadersTest.java | 2 +-
...TransactionErrorHandlerRedeliveryDelayTest.java | 6 ++---
.../jms/temp/TemporaryQueueRouteTest.java | 2 +-
44 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/BrowsableQueueTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/BrowsableQueueTest.java
index 3bbc3bc19b5..0442ca373fa 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/BrowsableQueueTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/BrowsableQueueTest.java
@@ -29,8 +29,8 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class BrowsableQueueTest extends AbstractJMSTest {
private static final Logger LOG = LoggerFactory.getLogger(BrowsableQueueTest.class);
- protected String componentName = "activemq";
- protected Object[] expectedBodies = { "body1", "body2", "body3", "body4", "body5", "body6", "body7", "body8" };
+ protected final String componentName = "activemq";
+ protected final Object[] expectedBodies = { "body1", "body2", "body3", "body4", "body5", "body6", "body7", "body8" };
@Test
public void testSendMessagesThenBrowseQueue() {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsKeepLastModifiedTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsKeepLastModifiedTest.java
index d02b7d50c49..53e61f5fa10 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsKeepLastModifiedTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsKeepLastModifiedTest.java
@@ -30,7 +30,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class FileRouteJmsKeepLastModifiedTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
private final File inbox = new File("target/FileRouteJmsKeepLastModifiedTest/inbox/hello.txt");
@Override
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsPreMoveTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsPreMoveTest.java
index 94740485d12..09906b6f7d0 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsPreMoveTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteJmsPreMoveTest.java
@@ -28,7 +28,7 @@ import static org.apache.camel.test.junit5.TestSupport.deleteDirectory;
*/
public class FileRouteJmsPreMoveTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Override
@BeforeEach
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsTest.java
index 2e43287ea4b..a814f235560 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsTest.java
@@ -28,7 +28,7 @@ import static org.apache.camel.test.junit5.TestSupport.deleteDirectory;
*/
public class FileRouteToJmsTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRouteToFile() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsToFileTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsToFileTest.java
index f8a07813298..7c9903a34d7 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsToFileTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/FileRouteToJmsToFileTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
*/
public class FileRouteToJmsToFileTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRouteFileToFile() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartListenerTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartListenerTest.java
index 7d5b5da0180..74727f55da2 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartListenerTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartListenerTest.java
@@ -33,7 +33,7 @@ import static org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
@Timeout(60)
public class JmsAsyncStartListenerTest extends AbstractPersistentJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testAsyncStartListener() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartStopListenerTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartStopListenerTest.java
index 0d513b5434f..1481a659a4e 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartStopListenerTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStartStopListenerTest.java
@@ -42,7 +42,7 @@ public class JmsAsyncStartStopListenerTest extends CamelTestSupport {
@RegisterExtension
public ActiveMQService service = ActiveMQServiceFactory.createPersistentVMService();
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testAsyncStartListener() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStopListenerTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStopListenerTest.java
index 4578745e153..b8facb3c8b8 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStopListenerTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAsyncStopListenerTest.java
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Timeout;
@Timeout(60)
public class JmsAsyncStopListenerTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testAsyncStopListener() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsClientAckTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsClientAckTest.java
index d76f77a13c3..31108768426 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsClientAckTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsClientAckTest.java
@@ -28,7 +28,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
public class JmsClientAckTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testJmsClientAck() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
index 268d27819a5..cf37f9f26ea 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public class JmsComponentTest extends CamelTestSupport {
- protected String componentName = "activemq123";
+ protected final String componentName = "activemq123";
protected JmsEndpoint endpoint;
@Test
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsCustomHeaderFilterStrategyTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsCustomHeaderFilterStrategyTest.java
index 13bb0dde87b..29284b5c1c5 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsCustomHeaderFilterStrategyTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsCustomHeaderFilterStrategyTest.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
public class JmsCustomHeaderFilterStrategyTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testCustomHeaderFilterStrategy() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDestinationResolverTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDestinationResolverTest.java
index ead6d8ffec4..aa9445f978f 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDestinationResolverTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDestinationResolverTest.java
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
public class JmsDestinationResolverTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testSendAndReceiveMessage() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutBeanReturnNullTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutBeanReturnNullTest.java
index 20696f31fec..18c8d1a4715 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutBeanReturnNullTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutBeanReturnNullTest.java
@@ -102,7 +102,7 @@ public class JmsInOutBeanReturnNullTest extends AbstractJMSTest {
public static final class MyBean implements Serializable {
private static final long serialVersionUID = 1L;
- public String name;
+ public final String name;
public MyBean(String name) {
this.name = name;
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutFixedReplyQueueTimeoutTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutFixedReplyQueueTimeoutTest.java
index 7a4d6382f81..2ec3b1d88bc 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutFixedReplyQueueTimeoutTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutFixedReplyQueueTimeoutTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsInOutFixedReplyQueueTimeoutTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testOk() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutIndividualRequestTimeoutTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutIndividualRequestTimeoutTest.java
index 7b48e0ba772..f318331f9d2 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutIndividualRequestTimeoutTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutIndividualRequestTimeoutTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsInOutIndividualRequestTimeoutTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testOk() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyComponentTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyComponentTest.java
index 70617504cf3..b428e81bedd 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyComponentTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyComponentTest.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
public class JmsMessageCreatedStrategyComponentTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testMessageCreatedStrategy() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
index c9cc2c2cfd6..a304f51660b 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
public class JmsMessageCreatedStrategyEndpointTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@BindToRegistry("myStrategy")
private final MyMessageCreatedStrategy strategy = new MyMessageCreatedStrategy();
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageTimestampTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageTimestampTest.java
index 1ddac4bcf53..8bb014a87cd 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageTimestampTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageTimestampTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test;
public class JmsMessageTimestampTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testMessageTimestamp() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsNoRequestTimeoutTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsNoRequestTimeoutTest.java
index 38f80ab6016..9f3d2b05892 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsNoRequestTimeoutTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsNoRequestTimeoutTest.java
@@ -27,7 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsNoRequestTimeoutTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testNoRequestTimeout() {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsQosRouteTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsQosRouteTest.java
index 3e5c292a5e5..53d44999428 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsQosRouteTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsQosRouteTest.java
@@ -21,7 +21,7 @@ import org.apache.camel.component.mock.MockEndpoint;
import org.junit.jupiter.api.Test;
public class JmsQosRouteTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testJmsRoutePreserveQos() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest.java
index 8f65d4c5f62..ed6a0bf93f8 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest.java
@@ -29,7 +29,7 @@ public class JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest extends Abs
private static final Logger LOG = LoggerFactory.getLogger(JmsRequestReplyProcessRepliesConcurrentUsingThreadsTest.class);
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRequestReplyWithConcurrent() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
index d1c17d44c3c..cbeda5423ac 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyTemporaryCacheNoneTest.java
@@ -27,7 +27,7 @@ import static org.junit.jupiter.api.Assertions.fail;
public class JmsRequestReplyTemporaryCacheNoneTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Override
public String getComponentName() {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
index 1dd8ecdc779..d9bf60ad66b 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
@@ -55,17 +55,17 @@ import static org.junit.jupiter.api.Assertions.fail;
public class JmsRouteRequestReplyTest extends CamelTestSupport {
protected static final String REPLY_TO_DESTINATION_SELECTOR_NAME = "camelProducer";
- protected static String componentName = "amq";
- protected static String componentName1 = "amq1";
- protected static String endpointUriA = componentName + ":queue:JmsRouteRequestReplyTest.a";
- protected static String endpointUriB = componentName + ":queue:JmsRouteRequestReplyTest.b";
- protected static String endpointUriB1 = componentName1 + ":queue:JmsRouteRequestReplyTest.b";
+ protected static final String COMPONENT_NAME = "amq";
+ protected static final String COMPONENT_NAME_1 = "amq1";
+ protected static String endpointUriA = COMPONENT_NAME + ":queue:JmsRouteRequestReplyTest.a";
+ protected static String endpointUriB = COMPONENT_NAME + ":queue:JmsRouteRequestReplyTest.b";
+ protected static String endpointUriB1 = COMPONENT_NAME_1 + ":queue:JmsRouteRequestReplyTest.b";
// note that the replyTo both A and B endpoints share the persistent replyTo queue,
// which is one more way to verify that reply listeners of A and B endpoints don't steal each other messages
protected static String endpointReplyToUriA
- = componentName + ":queue:JmsRouteRequestReplyTest.a?replyTo=queue:JmsRouteRequestReplyTest.a.reply";
+ = COMPONENT_NAME + ":queue:JmsRouteRequestReplyTest.a?replyTo=queue:JmsRouteRequestReplyTest.a.reply";
protected static String endpointReplyToUriB
- = componentName + ":queue:JmsRouteRequestReplyTest.b?replyTo=queue:JmsRouteRequestReplyTest.a.reply";
+ = COMPONENT_NAME + ":queue:JmsRouteRequestReplyTest.b?replyTo=queue:JmsRouteRequestReplyTest.a.reply";
protected static String request = "Hello World";
protected static String expectedReply = "Re: " + request;
@@ -149,7 +149,7 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
JmsComponent jmsComponent = jmsComponentAutoAcknowledge(connectionFactory);
jmsComponent.getConfiguration().setUseMessageIDAsCorrelationID(true);
jmsComponent.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jmsComponent);
+ context.addComponent(COMPONENT_NAME, jmsComponent);
return context;
}
}
@@ -166,7 +166,7 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
JmsComponent jms = jmsComponentAutoAcknowledge(connectionFactory);
jms.getConfiguration().setUseMessageIDAsCorrelationID(false);
jms.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jms);
+ context.addComponent(COMPONENT_NAME, jms);
return context;
};
@@ -178,7 +178,7 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
jms.getConfiguration().setReplyToDestinationSelectorName(REPLY_TO_DESTINATION_SELECTOR_NAME);
jms.getConfiguration().setUseMessageIDAsCorrelationID(true);
jms.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jms);
+ context.addComponent(COMPONENT_NAME, jms);
return context;
};
@@ -190,7 +190,7 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
jms.getConfiguration().setReplyToDestinationSelectorName(REPLY_TO_DESTINATION_SELECTOR_NAME);
jms.getConfiguration().setUseMessageIDAsCorrelationID(false);
jms.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jms);
+ context.addComponent(COMPONENT_NAME, jms);
return context;
};
@@ -199,12 +199,12 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
ConnectionFactory connectionFactory = createConnectionFactory(brokerUrl, null);
JmsComponent jms = jmsComponentAutoAcknowledge(connectionFactory);
jms.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jms);
+ context.addComponent(COMPONENT_NAME, jms);
JmsComponent jms1 = jmsComponentAutoAcknowledge(connectionFactory);
jms1.getConfiguration().setUseMessageIDAsCorrelationID(false);
jms1.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName1, jms1);
+ context.addComponent(COMPONENT_NAME_1, jms1);
return context;
};
@@ -214,12 +214,12 @@ public class JmsRouteRequestReplyTest extends CamelTestSupport {
JmsComponent jms = jmsComponentAutoAcknowledge(connectionFactory);
jms.getConfiguration().setUseMessageIDAsCorrelationID(true);
jms.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName, jms);
+ context.addComponent(COMPONENT_NAME, jms);
JmsComponent jms1 = jmsComponentAutoAcknowledge(connectionFactory);
jms1.getConfiguration().setUseMessageIDAsCorrelationID(true);
jms1.getConfiguration().setConcurrentConsumers(maxServerTasks);
- context.addComponent(componentName1, jms1);
+ context.addComponent(COMPONENT_NAME_1, jms1);
return context;
};
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteToFileTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteToFileTest.java
index 3c834c5fc84..5b3f9212263 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteToFileTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteToFileTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
*/
public class JmsRouteToFileTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRouteToFile() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
index 111fb324bc3..28a1aa855d9 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsRouteWithCustomListenerContainerTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@BindToRegistry("orderService")
private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
index f00cc10466a..cdc64436e0c 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
@@ -30,7 +30,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsRouteWithInOnlyAndMultipleAcksTest extends AbstractJMSTest {
- protected String componentName = "amq";
+ protected final String componentName = "amq";
@BindToRegistry("orderService")
private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
index ebf4ed6528d..e519c6a9aaf 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
@@ -33,7 +33,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
@Timeout(10)
public class JmsRouteWithInOnlyTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@BindToRegistry("orderService")
private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipTest.java
index 441286c439a..a49856067de 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipTest.java
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
*/
public class JmsRoutingSlipTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testJmsRoutingSlip() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSelectorOptionTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSelectorOptionTest.java
index d7a0f28f54a..972ef3298e6 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSelectorOptionTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSelectorOptionTest.java
@@ -27,7 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
public class JmsSelectorOptionTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testJmsMessageWithSelector() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSessionTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSessionTest.java
index 4fd67f602b5..1af4ac707bb 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSessionTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSessionTest.java
@@ -26,7 +26,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
public class JmsSessionTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testJmsSession() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleHeaderTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleHeaderTest.java
index a9e1888a652..5eec8aa61ff 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleHeaderTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleHeaderTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class JmsSimpleHeaderTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testByteJMSHeaders() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleInOnlyNoMutateTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleInOnlyNoMutateTest.java
index fb7c3a29c3b..b155a7f4fcd 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleInOnlyNoMutateTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleInOnlyNoMutateTest.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
*/
public class JmsSimpleInOnlyNoMutateTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRequestReplyNoMutate() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
index fe7c6532883..2321beaa5a0 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestCustomReplyToTest.java
@@ -40,7 +40,7 @@ public class JmsSimpleRequestCustomReplyToTest extends AbstractJMSTest {
private static final Logger LOG = LoggerFactory.getLogger(JmsSimpleRequestCustomReplyToTest.class);
private static String myReplyTo;
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
private CountDownLatch latch = new CountDownLatch(1);
@Test
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestLateReplyTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestLateReplyTest.java
index 93d85b352b8..6af58491f04 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestLateReplyTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestLateReplyTest.java
@@ -42,7 +42,7 @@ public class JmsSimpleRequestLateReplyTest extends AbstractJMSTest {
private static final Logger LOG = LoggerFactory.getLogger(JmsSimpleRequestLateReplyTest.class);
private static Destination replyDestination;
private static String cid;
- protected String expectedBody = "Late Reply";
+ protected final String expectedBody = "Late Reply";
protected JmsComponent activeMQComponent;
private final CountDownLatch latch = new CountDownLatch(1);
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReply2Test.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReply2Test.java
index 4a660a05a84..a8be697ec33 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReply2Test.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReply2Test.java
@@ -27,7 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
*/
public class JmsSimpleRequestReply2Test extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testWithInOnly() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyFixedReplyQueueTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyFixedReplyQueueTest.java
index 2bda9d4281a..40b3622a28b 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyFixedReplyQueueTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyFixedReplyQueueTest.java
@@ -27,7 +27,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
*/
public class JmsSimpleRequestReplyFixedReplyQueueTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testWithInOnly() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyTest.java
index 6b8c0fc3136..a8d2ed297d7 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsSimpleRequestReplyTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
@TestInstance(TestInstance.Lifecycle.PER_METHOD)
public class JmsSimpleRequestReplyTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testRequestReply() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PayloadByteArrayJmsTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PayloadByteArrayJmsTest.java
index 127b8eded43..133f1a60052 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PayloadByteArrayJmsTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PayloadByteArrayJmsTest.java
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
*/
public class PayloadByteArrayJmsTest extends AbstractJMSTest {
- protected String componentName = "activemq";
+ protected final String componentName = "activemq";
@Test
public void testReaderShouldBeByteArray() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/SerializableRequestDto.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/SerializableRequestDto.java
index ac61e50faf4..589999346db 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/SerializableRequestDto.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/SerializableRequestDto.java
@@ -20,7 +20,7 @@ import java.io.Serializable;
public class SerializableRequestDto implements Serializable {
private static final long serialVersionUID = 1L;
- public String customerName;
+ public final String customerName;
public SerializableRequestDto() {
customerName = "Default";
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/JmsDiscoveryTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/JmsDiscoveryTest.java
index c81d38ff354..34c9dba8230 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/JmsDiscoveryTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/JmsDiscoveryTest.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
import static org.assertj.core.api.Assertions.assertThat;
public class JmsDiscoveryTest extends AbstractJMSTest {
- protected MyRegistry myRegistry = new MyRegistry();
+ protected final MyRegistry myRegistry = new MyRegistry();
@Test
public void testDiscovery() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateHeadersTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateHeadersTest.java
index 07b17270610..7838077ac47 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateHeadersTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateHeadersTest.java
@@ -32,10 +32,10 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class ActiveMQPropagateHeadersTest extends AbstractJMSTest {
- protected Object expectedBody = "<time>" + new Date() + "</time>";
- protected ActiveMQQueue replyQueue = new ActiveMQQueue("test.reply.queue.ActiveMQPropagateHeadersTest");
- protected String correlationID = "ABC-123";
- protected String messageType = getClass().getName();
+ protected final Object expectedBody = "<time>" + new Date() + "</time>";
+ protected final ActiveMQQueue replyQueue = new ActiveMQQueue("test.reply.queue.ActiveMQPropagateHeadersTest");
+ protected final String correlationID = "ABC-123";
+ protected final String messageType = getClass().getName();
@Test
public void testForwardingAMessageAcrossJMSKeepingCustomJMSHeaders() throws Exception {
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateSerializableHeadersTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateSerializableHeadersTest.java
index 158147f4e16..f1f56bfb722 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateSerializableHeadersTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/ActiveMQPropagateSerializableHeadersTest.java
@@ -37,7 +37,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class ActiveMQPropagateSerializableHeadersTest extends AbstractJMSTest {
- protected Object expectedBody = "<time>" + new Date() + "</time>";
+ protected final Object expectedBody = "<time>" + new Date() + "</time>";
protected ActiveMQQueue replyQueue = new ActiveMQQueue("ActiveMQPropagateSerializableHeadersTest.reply.queue");
protected String correlationID = "ABC-123";
protected String messageType = getClass().getName();
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/TransactionErrorHandlerRedeliveryDelayTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/TransactionErrorHandlerRedeliveryDelayTest.java
index a9467c88e8f..886ccdb4fb7 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/TransactionErrorHandlerRedeliveryDelayTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/TransactionErrorHandlerRedeliveryDelayTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
*/
public class TransactionErrorHandlerRedeliveryDelayTest extends CamelSpringTestSupport {
- private static LongAdder counter = new LongAdder();
+ private static final LongAdder COUNTER = new LongAdder();
@Override
protected AbstractApplicationContext createApplicationContext() {
@@ -56,8 +56,8 @@ public class TransactionErrorHandlerRedeliveryDelayTest extends CamelSpringTestS
@Override
public void process(Exchange exchange) {
- int counterValue = counter.intValue();
- counter.increment();
+ int counterValue = COUNTER.intValue();
+ COUNTER.increment();
if (counterValue < 3) {
throw new IllegalArgumentException("Forced exception as counter is " + counterValue);
}
diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/TemporaryQueueRouteTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/TemporaryQueueRouteTest.java
index a06518e5c94..bdcc47bf5cc 100644
--- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/TemporaryQueueRouteTest.java
+++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/TemporaryQueueRouteTest.java
@@ -22,7 +22,7 @@ import org.apache.camel.component.mock.MockEndpoint;
import org.junit.jupiter.api.Test;
public class TemporaryQueueRouteTest extends AbstractJMSTest {
- protected String endpointUri = "activemq:temp-queue:TemporaryQueueRouteTest";
+ protected final String endpointUri = "activemq:temp-queue:TemporaryQueueRouteTest";
@Test
public void testSendMessage() throws Exception {