You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/23 19:23:49 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6757: Re-export modules individually to fix rustdocs
alamb opened a new pull request, #6757:
URL: https://github.com/apache/arrow-datafusion/pull/6757
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/6648
# Rationale for this change
When I am trying to use rustdocs to find certain classes it often fails to do so (see https://github.com/apache/arrow-datafusion/issues/6648 for more details)
# What changes are included in this PR?
1. Directly `pub use` the content of submodules rather than just the modules themselves
This means that rustdoc can now find all the classes directly:
<img width="1262" alt="Screenshot 2023-06-23 at 3 17 25 PM" src="https://github.com/apache/arrow-datafusion/assets/490673/7747d1e5-da02-49f4-b9b3-0a652d05a3af">
# Are these changes tested?
Existing tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
Better rust docs
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6757: Re-export modules individually to fix rustdocs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6757:
URL: https://github.com/apache/arrow-datafusion/pull/6757#issuecomment-1604768207
cc @dadepo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #6757: Re-export modules individually to fix rustdocs
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6757:
URL: https://github.com/apache/arrow-datafusion/pull/6757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org