You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/08 07:41:51 UTC
[GitHub] [flink] azagrebin opened a new pull request #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
azagrebin opened a new pull request #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667
## What is the purpose of the change
### Concurrent `TaskSlotTable` in test
The test called `taskSlotTable.allocateSlot` from the test main thread,
concurrently with `taskSlotTable.createSlotReport `while trying to register
RM in the main TM thread. This silently failed the RM registration in `TM.runAsync`.
As a result, RM.notifySlotAvailable was not called in TM.
The taskSlotTable is not thread-safe and must be accessed only from the main RPC thread of TM.
### Failure in `establishResourceManagerConnection`
Failure of `TaskExecutor#establishResourceManagerConnection` is not expected.
It completely breaks the connection mechanism to RM in TM.
As a hotfix, the PR suggests to log it on error level at least.
Alternatively, we can consider calling `TM.onFatalError` as a follow-up.
## Brief change log
The PR refactors the test to wait properly for RM registration
and allocate slots through gateway in TM thread.
The PR also uses proper testing RM/JM instead of mocks.
## Verifying this change
To verify, the test has been looped locally 30k times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on issue #11667: [FLINK-15936] Harden
TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-611410901
Other calls technically happen when the state is synced with the test thread.
On the other hand, it can diverge in future and I replaced them by similar gateway calls which should be enough to check the original intention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159559195) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159663627",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159663627) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin closed pull request #11667: [FLINK-15936] Harden
TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159249931) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199)
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159559195) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11667:
[FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#discussion_r406094567
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1005,6 +1012,23 @@ private void requestSlots(TaskExecutorGateway tmGateway, Iterable<? extends Allo
}
}
+ private Either<Acknowledge, Throwable> submitNoOpInvokableTask(
+ AllocationID allocationId,
+ TestingJobMasterGateway jobMasterGateway,
+ TaskExecutorGateway tmGateway) throws IOException {
+ final TaskDeploymentDescriptor tdd = TaskDeploymentDescriptorBuilder
+ .newBuilder(jobId, NoOpInvokable.class)
+ .setAllocationId(allocationId)
+ .build();
+
+ try {
+ // submit the task without having acknowledge the offered slots
Review comment:
this isn't necessarily true is it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159663627",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159559195) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272)
* 82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159663627) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11667: [FLINK-15936] Harden
TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11667:
[FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#discussion_r405987107
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -988,6 +945,43 @@ public void testSubmitTaskBeforeAcceptSlot() throws Exception {
}
}
+ private TestingResourceManagerGateway createRmWithTmRegisterAndNotifySlotHooks(
+ InstanceID registrationId,
+ OneShotLatch taskExecutorIsRegistered,
+ CompletableFuture<Tuple3<InstanceID, SlotID, AllocationID>> availableSlotFuture) {
+ final TestingResourceManagerGateway resourceManagerGateway = new TestingResourceManagerGateway();
+ resourceManagerLeaderRetriever.notifyListener(
+ resourceManagerGateway.getAddress(),
+ resourceManagerGateway.getFencingToken().toUUID());
+
+ resourceManagerGateway.setRegisterTaskExecutorFunction(
+ taskExecutorRegistration -> CompletableFuture.completedFuture(
+ new TaskExecutorRegistrationSuccess(registrationId, resourceManagerGateway.getOwnResourceId(),
+ new ClusterInformation("localhost", 1234))));
+
+ resourceManagerGateway.setNotifySlotAvailableConsumer(availableSlotFuture::complete);
+
+ resourceManagerGateway.setSendSlotReportFunction(ignored -> {
+ taskExecutorIsRegistered.trigger();
+ return CompletableFuture.completedFuture(Acknowledge.get());
+ });
+ return resourceManagerGateway;
+ }
+
+ private TaskManagerServices createTaskManagerServicesWithTaskSlotTable(
+ TaskSlotTable<Task> taskSlotTable) throws IOException {
+ return new TaskManagerServicesBuilder()
+ .setUnresolvedTaskManagerLocation(unresolvedTaskManagerLocation)
+ .setShuffleEnvironment(nettyShuffleEnvironment)
+ .setTaskSlotTable(taskSlotTable)
+ .setJobLeaderService(new JobLeaderService(
+ unresolvedTaskManagerLocation,
+ RetryingRegistrationConfiguration.defaultConfiguration()))
+ .setJobManagerTable(new JobManagerTable())
+ .setTaskStateManager( createTaskExecutorLocalStateStoresManager())
Review comment:
remove leading space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159559195) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272)
* 82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11667:
[FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#discussion_r406090698
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1005,6 +1012,23 @@ private void requestSlots(TaskExecutorGateway tmGateway, Iterable<? extends Allo
}
}
+ private Either<Acknowledge, Throwable> submitNoOpInvokableTask(
+ AllocationID allocationId,
+ TestingJobMasterGateway jobMasterGateway,
+ TaskExecutorGateway tmGateway) throws IOException {
+ final TaskDeploymentDescriptor tdd = TaskDeploymentDescriptorBuilder
+ .newBuilder(jobId, NoOpInvokable.class)
+ .setAllocationId(allocationId)
+ .build();
+
+ try {
+ // submit the task without having acknowledge the offered slots
+ return Either.Left(tmGateway.submitTask(tdd, jobMasterGateway.getFencingToken(), timeout).join());
+ } catch (CompletionException e) {
+ return Either.Right(e.getCause());
Review comment:
Why not just let the cause bubble up, possibly enriching it?
You could then use `assertThrows` for checking the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159559195) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159249931) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7272",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159559195",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
}, {
"hash" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159663627",
"triggerID" : "82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82ce0e1dcd7ab74da0e33aeeb8c02dd1ef789e61 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159663627) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7298)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11667: [FLINK-15936] Harden
TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610805467
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e (Wed Apr 08 07:45:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159249931) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199)
* cebbe3ac81e1f2e35f71b37778bee7a8a71e0da8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159249931) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11667: [FLINK-15936]
Harden TaskExecutorTest#testSlotAcceptance
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11667: [FLINK-15936] Harden TaskExecutorTest#testSlotAcceptance
URL: https://github.com/apache/flink/pull/11667#issuecomment-610810071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
}, {
"hash" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159249931",
"triggerID" : "475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 475a7a5a419a3e7375d5b4b372d7c5ccf5d6e84e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159249931) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7199)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services