[jira] Commented: (WICKET-3291) Refactoring of RequestCycle has reintroduced WICKET-689

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975796#action_12975796 ] 

Martin Grigorov commented on WICKET-3291:
-----------------------------------------

There is org.apache.wicket.Application.setRequestCycleProvider(IRequestCycleProvider) where you define the custom provider.

IProvider is used for many other settings too and it is easier to setup one provider and later change it.

Does this solve your problem ?

> Refactoring of RequestCycle has reintroduced WICKET-689
> -------------------------------------------------------
>
>                 Key: WICKET-3291
>                 URL: https://issues.apache.org/jira/browse/WICKET-3291
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>
> Three years ago I requested a newRequestCycle method in Application to make it as easy to integrate custom RequestCycle implementations as it is to integrate custom Session implementations.  The Wicket team added the method and also removed the IRequestCycleFactory interface.
> But in the 1.5-M3 code base I see the exact same situation:  IRequestCycleFactory has returned, only now it's called IRequestCycleProvider, and again there is no non-final Application method that I can override to instantiate my own RequestCycle.
> I think as a general principle, we should look skeptically at interfaces have one method and that only exist as a member of one class and are only called from that class;  it seems like a complicated way of overriding a method.  Possibly there's a Wicket application out there somewhere that would benefit from the interface.  But for most of us, who are creating our own Application subclasses anyway, it's much easier to just override newRequestCycle, in the same way that we override newSession.
> See also WICKET-689.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.