You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/09/27 11:18:30 UTC
[GitHub] [zeppelin] martin-g opened a new pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
martin-g opened a new pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237
### What is this PR for?
Replaces the usage of PhantomJS for the JavaScript tests with headless Firefox.
PhantomJS is not maintained since few years.
Using a real browser will make the tests more close to the real usage.
### What type of PR is it?
Improvement
### What is the Jira issue?
* Jira https://issues.apache.org/jira/browse/ZEPPELIN-5542
### How should this be tested?
* `mvn test -Pweb-e2e` should pass for `zeppenlin-web` module
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] martin-g commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-937486253
[PhantomJS](https://phantomjs.org/) is a wrapper around QtWebKit.
[Puppeteer](https://puppeteer.github.io/puppeteer/) is a wrapper around Chromium/Google Chrome.
Since you already use Karma.js IMO there is no need to switch to totally new solution. Just change the [karma launcher](http://karma-runner.github.io/6.3/config/browsers.html).
One advantage of Puppeteer is that it can download the browser for you. With Karma.js you have to make sure the browser is pre-installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-937442245
@martin-g & @EricGao888 What's the difference between `Puppeteer` and `PhantomJS`, I am not frontend expert. If there's no major difference, I am fine with any of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] martin-g commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-929066870
I've tried to use Puppeteer in another project about an year ago and I wasn't able to make it work for some reason :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] epugh commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-929109023
I might just try and copy what you did here for testing on https://github.com/o19s/quepid ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-940786784
I will merge this if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] martin-g commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-937486253
[PhantomJS](https://phantomjs.org/) is a wrapper around QtWebKit.
[Puppeteer](https://puppeteer.github.io/puppeteer/) is a wrapper around Chromium/Google Chrome.
Since you already use Karma.js IMO there is no need to switch to totally new solution. Just change the [karma launcher](http://karma-runner.github.io/6.3/config/browsers.html).
One advantage of Puppeteer is that it can download the browser for you. With Karma.js you have to make sure the browser is pre-installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] epugh commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-929057489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] epugh commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-929057489
Any thoughts on using Puppeteer instead? I migrated from PhantomJS to that project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-938289335
> One advantage of Puppeteer is that it can download the browser for you. With Karma.js you have to make sure the browser is pre-installed.
It looks attractive when we test on the local machine. BTW, I'm also not an expert for frontend so I'm not sure how it takes cost when we change it but I, sometimes, hope we could change to Puppeteer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] martin-g commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-929066870
I've tried to use Puppeteer in another project about an year ago and I wasn't able to make it work for some reason :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu edited a comment on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-937442245
@martin-g & @epugh What's the difference between `Puppeteer` and `PhantomJS`, I am not frontend expert. If there's no major difference, I am fine with any of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4237: ZEPPELIN-5542 Use headless Firefox instead of PhantomJS
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4237:
URL: https://github.com/apache/zeppelin/pull/4237#issuecomment-937442245
@martin-g & @EricGao888 What's the difference between `Puppeteer` and `PhantomJS`, I am not frontend expert. If there's no major difference, I am fine with any of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org