You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Krisztian Kasa <kk...@hortonworks.com> on 2020/02/04 05:26:34 UTC
Re: Review Request 72073: HIVE-22808
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72073/
-----------------------------------------------------------
(Updated Feb. 4, 2020, 5:26 a.m.)
Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
Bugs: HIVE-22808
https://issues.apache.org/jira/browse/HIVE-22808
Repository: hive-git
Description
-------
HiveRelFieldTrimmer does not handle HiveTableFunctionScan
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java ffa2a1f262
ql/src/test/results/clientpositive/except_all.q.out 020cba4287
ql/src/test/results/clientpositive/intersect_all_rj.q.out b8ff98ae79
ql/src/test/results/clientpositive/llap/intersect_all_rj.q.out cdfbc2239e
Diff: https://reviews.apache.org/r/72073/diff/2/
Changes: https://reviews.apache.org/r/72073/diff/1-2/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa
Re: Review Request 72073: HIVE-22808
Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72073/
-----------------------------------------------------------
(Updated Feb. 5, 2020, 12:53 p.m.)
Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
Bugs: HIVE-22808
https://issues.apache.org/jira/browse/HIVE-22808
Repository: hive-git
Description
-------
HiveRelFieldTrimmer does not handle HiveTableFunctionScan
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 9bf42ed384
ql/src/test/results/clientpositive/except_all.q.out 020cba4287
ql/src/test/results/clientpositive/intersect_all_rj.q.out b8ff98ae79
ql/src/test/results/clientpositive/llap/intersect_all_rj.q.out cdfbc2239e
Diff: https://reviews.apache.org/r/72073/diff/4/
Changes: https://reviews.apache.org/r/72073/diff/3-4/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa
Re: Review Request 72073: HIVE-22808
Posted by Krisztian Kasa <kk...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72073/
-----------------------------------------------------------
(Updated Feb. 5, 2020, 5:33 a.m.)
Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
Bugs: HIVE-22808
https://issues.apache.org/jira/browse/HIVE-22808
Repository: hive-git
Description
-------
HiveRelFieldTrimmer does not handle HiveTableFunctionScan
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 9bf42ed384
ql/src/test/results/clientpositive/except_all.q.out 020cba4287
ql/src/test/results/clientpositive/intersect_all_rj.q.out b8ff98ae79
ql/src/test/results/clientpositive/llap/intersect_all_rj.q.out cdfbc2239e
Diff: https://reviews.apache.org/r/72073/diff/3/
Changes: https://reviews.apache.org/r/72073/diff/2-3/
Testing
-------
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests
Thanks,
Krisztian Kasa
Re: Review Request 72073: HIVE-22808
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72073/#review219501
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java
Line 33 (original), 34 (patched)
<https://reviews.apache.org/r/72073/#comment307699>
It is not good idea to extend Logical nodes in Hive. Fix should instead be in RelFieldTrimmer to handle TableFunctionScan type.
Ideally it should be fixed in calcite, but for now we can copy the implementation of LogicalTableFunctionScan from calcite and resuse it for HiveTableFunctionScan
- Vineet Garg
On Feb. 4, 2020, 5:26 a.m., Krisztian Kasa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72073/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2020, 5:26 a.m.)
>
>
> Review request for hive, Jesús Camacho Rodríguez and Vineet Garg.
>
>
> Bugs: HIVE-22808
> https://issues.apache.org/jira/browse/HIVE-22808
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HiveRelFieldTrimmer does not handle HiveTableFunctionScan
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java ffa2a1f262
> ql/src/test/results/clientpositive/except_all.q.out 020cba4287
> ql/src/test/results/clientpositive/intersect_all_rj.q.out b8ff98ae79
> ql/src/test/results/clientpositive/llap/intersect_all_rj.q.out cdfbc2239e
>
>
> Diff: https://reviews.apache.org/r/72073/diff/2/
>
>
> Testing
> -------
>
> mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests
>
>
> Thanks,
>
> Krisztian Kasa
>
>