You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "twosom (via GitHub)" <gi...@apache.org> on 2023/06/23 16:29:20 UTC
[GitHub] [lucene] twosom opened a new pull request, #12390: move CSVUtil to common from analyzer nori and kuromoji
twosom opened a new pull request, #12390:
URL: https://github.com/apache/lucene/pull/12390
### Description
This PR moves the `CSVUtil` class that existed separately in the Analyzer `Nori` and `Kuromoji` to the module `:analysis:common`.
By consolidating the `CSVUtil` class, we can prevent duplication and improve maintainability across the Analyzer `Nori` and `Kuromoji`.
Closes #12389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] move CSVUtil to common from analyzer nori and kuromoji [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12390:
URL: https://github.com/apache/lucene/pull/12390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] move CSVUtil to common from analyzer nori and kuromoji [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12390:
URL: https://github.com/apache/lucene/pull/12390#issuecomment-1790813760
I merged to main but there are quite a few conflicts on backport to 9.x -- any chance you could open a backport PR @twosom? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] move CSVUtil to common from analyzer nori and kuromoji [lucene]
Posted by "twosom (via GitHub)" <gi...@apache.org>.
twosom commented on PR #12390:
URL: https://github.com/apache/lucene/pull/12390#issuecomment-1794844758
> I merged to main but there are quite a few conflicts on backport to 9.x -- any chance you could open a backport PR @twosom? Thanks!
OK! I'll open backport PR ASAP! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org