[GitHub] [incubator-doris] wangbo commented on a change in pull request #5262: (#5261) System metric init failed cause be start failed

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #5262:
URL: https://github.com/apache/incubator-doris/pull/5262#discussion_r560664760



##########
File path: be/src/common/daemon.cpp
##########
@@ -289,6 +289,11 @@ void Daemon::start() {
     CHECK(st.ok()) << st.to_string();
 
     if (config::enable_metric_calculator) {
+        CHECK(DorisMetrics::instance()->is_inited())

Review comment:
       If some check failed could also cause system metrics init failed,such as disk or inet interface.
   So using a init field seems better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org