[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #34: Remove pekko-grpc prefix from project ids

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #34:
URL: https://github.com/apache/incubator-pekko-grpc/pull/34#discussion_r1119885104


##########
build.sbt:
##########
@@ -166,19 +173,20 @@ lazy val benchmarks = Project(id = "benchmarks", base = file("benchmarks"))
   .enablePlugins(JmhPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
+    name := s"$pekkoPrefix-benchmarks",
     crossScalaVersions := Dependencies.Versions.CrossScalaForLib,
     scalaVersion := Dependencies.Versions.CrossScalaForLib.head,
     (publish / skip) := true)
   .settings(MetaInfLicenseNoticeCopy.settings)
 
-lazy val docs = Project(id = "pekko-grpc-docs", base = file("docs"))
+lazy val docs = Project(id = "docs", base = file("docs"))
 // Make sure code generation is run:
   .dependsOn(pluginTesterScala)
   .dependsOn(pluginTesterJava)
   .enablePlugins(AkkaParadoxPlugin, ParadoxSitePlugin, PreprocessPlugin, PublishRsyncPlugin)
   .disablePlugins(MimaPlugin)
   .settings(
-    name := "Apache Pekko gRPC",
+    name := s"$pekkoPrefix-docs",

Review Comment:
   While the `name` here is irrelevant, its highly misleading and also quite different to the rest of the pekko projects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org