You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/23 04:12:59 UTC
[GitHub] [airflow] houqp opened a new pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
houqp opened a new pull request #9945:
URL: https://github.com/apache/airflow/pull/9945
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Also adds simple spec validation automation script to guard against future regressions.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459208161
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
https://www.github.com/wework/speccy/tree/master/rules%2Fdefault.yaml
Please look at: operation-operationId
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459207786
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
Should we add new linter at all? I think we can also add new rules to current linters
https://www.github.com/wework/speccy/tree/master/rules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459209096
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
https://meta.stoplight.io/docs/spectral/README.md?_ga=2.94361181.1790267361.1595478554-125598717.1595478554
> What is the difference between Spectral and Speccy
Speccy was a great inspiration for Spectral, but was designed to work only with OpenAPI v3. Spectral can apply rules to any JSON/YAML object (including OpenAPI v2/v3 and AsyncAPI).
> Speccy has been abandoned, but Spectral is steaming ahead, adding loads of functionality like custom functions, exceptions, and AsyncAPI support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459950997
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L194-L204
We already have two linters for API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9945:
URL: https://github.com/apache/airflow/pull/9945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459207035
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
@potiuk i added the install command here directly because it's only one line, let me know if you prefer me to wrap everything into one script inside `scripts/ci` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r460371208
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
ha, my bad, today i learned ripgrep doesn't search keyword in hidden files by default :( Thanks for pointing that out, i will switch to use precommit hook.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r460384026
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
@mik-laj switched to validate with speccy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459852613
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
@mik-laj before I look into speccy, this is not something we are currently using right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9945: add missing x-openapi-router-controller to dagRun endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9945:
URL: https://github.com/apache/airflow/pull/9945#discussion_r459950997
##########
File path: .github/workflows/ci.yml
##########
@@ -548,6 +548,13 @@ jobs:
with:
workflow_id: ${{ env.WORKFLOW_ID }}
access_token: ${{ github.token }}
+ - uses: actions/setup-python@v1
+ with:
+ python-version: '3.x'
+ - name: "Validate OpenAPI spec"
+ run: |
+ pip install PyYAML
Review comment:
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L194-L204
We already have two checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org