[GitHub] [doris] mrhhsg commented on a diff in pull request #20482: [improvement](sink) reuse rows buffer in msyql_result_writer

["mrhhsg (via GitHub)" <gi...@apache.org>]

mrhhsg commented on code in PR #20482:
URL: https://github.com/apache/doris/pull/20482#discussion_r1220638139


##########
be/src/util/mysql_row_buffer.cpp:
##########
@@ -80,6 +80,25 @@ MysqlRowBuffer<is_binary_format>::MysqlRowBuffer()
           _dynamic_mode(0),
           _len_pos(0) {}
 
+template <bool is_binary_format>
+MysqlRowBuffer<is_binary_format>::MysqlRowBuffer(MysqlRowBuffer<is_binary_format>&& other) {

Review Comment:
   This pull request introduced a change where a std::vector of MysqlRowBuffer was created to reuse the buffer. When the vector needs to be resized, the move constructor will be called.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org