[GitHub] [flink-kubernetes-operator] zch93 commented on pull request #524: [FLINK-30405] Add ResourceLifecycleStatus to CommonStatus and printer column

["zch93 (via GitHub)" <gi...@apache.org>]

zch93 commented on PR #524:
URL: https://github.com/apache/flink-kubernetes-operator/pull/524#issuecomment-1419715198

   > I don't see in the code where we set this field?
   
   My feeling is that, there are some implicit setter in the code. For example if I tried to add the `@PrinterColumn` annotation to fields from the `JobStatus` like `jobId` or `startTime`, or to any field from `ReconciliationStatus`, then despite there are not any explicit setter for those as well, the values appear when I run the `kubectl get flinkdeployments` command.
   
   I think since the `StatusRecorder ` extends the `CommonStatus` that has an affect for the new field as well with an implicit setter. There is a connection between different layers like the following:
   `ResourceLifecycleMetricTracker.onUpdate()` --> `LifecycleMetrics.onUpdate()`  --> `MetricManager.onUpdate()` --> StatusRecorder.patchAndCacheStatus()`  and `StatusRecorder` extends `CommonStatus`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org