You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/22 00:19:14 UTC

Review Request 45131: GEODE-923 Validation for idle Timeout set properly.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45131/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.


Repository: geode


Description
-------

Now before making connection passivate, we start time and then wait
    until connection has been destroy. And making sure it remains idle
    for idle timeout. Added 100 ms padding as well.


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java d0b2991 

Diff: https://reviews.apache.org/r/45131/diff/


Testing
-------


Thanks,

Hitesh Khamesra


Re: Review Request 45131: GEODE-923 Validation for idle Timeout set properly.

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45131/#review125897
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On March 21, 2016, 11:19 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45131/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 11:19 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Now before making connection passivate, we start time and then wait
>     until connection has been destroy. And making sure it remains idle
>     for idle timeout. Added 100 ms padding as well.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java d0b2991 
> 
> Diff: https://reviews.apache.org/r/45131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>


Re: Review Request 45131: GEODE-923 Validation for idle Timeout set properly.

Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45131/#review124680
-----------------------------------------------------------


Ship it!




Ship It!

- Bruce Schuchardt


On March 21, 2016, 11:19 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45131/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 11:19 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Now before making connection passivate, we start time and then wait
>     until connection has been destroy. And making sure it remains idle
>     for idle timeout. Added 100 ms padding as well.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java d0b2991 
> 
> Diff: https://reviews.apache.org/r/45131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>