You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dan Norris <pr...@gmail.com> on 2014/03/11 00:29:55 UTC
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated March 10, 2014, 11:29 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Changes
-------
Updates gradlew to check for the Python version before building Thrift. Also adds a Python check to the pex script.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs (updated)
-----
build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
build.gradle 9b8827ea05932620ebac4929838c158e853d73ae
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review38105
-----------------------------------------------------------
Kevin — are you happy with the updated diff?
- Bill Farner
On March 10, 2014, 11:29 p.m., Dan Norris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 11:29 p.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Bugs: AURORA-227
> https://issues.apache.org/jira/browse/AURORA-227
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-227: Aurora build should check for the Python version
>
>
> Diffs
> -----
>
> build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
> build.gradle 9b8827ea05932620ebac4929838c158e853d73ae
>
> Diff: https://reviews.apache.org/r/18537/diff/
>
>
> Testing
> -------
>
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
>
> :checkPythonVersion FAILED
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
>
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
>
>
> Thanks,
>
> Dan Norris
>
>
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review38953
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On March 21, 2014, 7:59 a.m., Dan Norris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 7:59 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-227
> https://issues.apache.org/jira/browse/AURORA-227
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-227: Aurora build should check for the Python version
>
>
> Diffs
> -----
>
> build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
> build.gradle 9b8827ea05932620ebac4929838c158e853d73ae
>
> Diff: https://reviews.apache.org/r/18537/diff/
>
>
> Testing
> -------
>
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
>
> :checkPythonVersion FAILED
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
>
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
>
>
> Thanks,
>
> Dan Norris
>
>
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review38962
-----------------------------------------------------------
Looks like this fails to apply - mind uploading a rebased version?
Patch is being applied from request 18537 with diff revision 2.
DEBUG:root:Running: git apply --index /tmp/tmpRDf1kq
DEBUG:root:Command exited with rc 1: ['git', 'apply', '--index', '/tmp/tmpRDf1kq']
error: patch failed: build.gradle:238
error: build.gradle: patch does not apply
---
- Kevin Sweeney
On March 21, 2014, 7:59 a.m., Dan Norris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 7:59 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-227
> https://issues.apache.org/jira/browse/AURORA-227
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-227: Aurora build should check for the Python version
>
>
> Diffs
> -----
>
> build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
> build.gradle 9b8827ea05932620ebac4929838c158e853d73ae
>
> Diff: https://reviews.apache.org/r/18537/diff/
>
>
> Testing
> -------
>
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
>
> :checkPythonVersion FAILED
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
>
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
>
>
> Thanks,
>
> Dan Norris
>
>
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review40922
-----------------------------------------------------------
Kevin, have you tried to submit this since it was last updated?
- Bill Farner
On March 29, 2014, 2:11 a.m., Dan Norris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
>
> (Updated March 29, 2014, 2:11 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-227
> https://issues.apache.org/jira/browse/AURORA-227
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-227: Aurora build should check for the Python version
>
>
> Diffs
> -----
>
> build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
> build.gradle 8e733e5f1fca2dbf5f0c100045fcc8c24e6b32d4
>
> Diff: https://reviews.apache.org/r/18537/diff/
>
>
> Testing
> -------
>
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
>
> :checkPythonVersion FAILED
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
>
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
>
>
> Thanks,
>
> Dan Norris
>
>
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated May 15, 2014, 2:47 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Rebase.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs (updated)
-----
build-support/pex 4cecdedcb7615de350ec36f5b8ceed2b2e0a2419
build.gradle 6f43feaaaae22215921c40efdf1bf1c7fdff9720
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review43083
-----------------------------------------------------------
kevints: Is there anything still blocking this that you see? It probably needs to be rebased again since it's been sitting for awhile.
- Dan Norris
On April 29, 2014, 3:15 a.m., Dan Norris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18537/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 3:15 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-227
> https://issues.apache.org/jira/browse/AURORA-227
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-227: Aurora build should check for the Python version
>
>
> Diffs
> -----
>
> build-support/pex 19c33210da7c390523b5890e20a137006345a62a
> build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840
>
> Diff: https://reviews.apache.org/r/18537/diff/
>
>
> Testing
> -------
>
> Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
>
> :checkPythonVersion FAILED
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
>
> * What went wrong:
> Execution failed for task ':checkPythonVersion'.
> > Build requires Python 2.6 or Python 2.7
>
>
> Thanks,
>
> Dan Norris
>
>
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated April 29, 2014, 3:15 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fix whitespace, print with a variable set to be in line with comment.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs (updated)
-----
build-support/pex 19c33210da7c390523b5890e20a137006345a62a
build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated April 27, 2014, 2:10 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Rebase and simplifies the Python check in Gradle based on jfarrell's suggestion.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs (updated)
-----
build-support/pex 19c33210da7c390523b5890e20a137006345a62a
build.gradle cb04661ecdbb17cac34f52167494bf08286c0841
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated March 29, 2014, 2:11 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Rebased patch against master.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs (updated)
-----
build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
build.gradle 8e733e5f1fca2dbf5f0c100045fcc8c24e6b32d4
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the
Python version
Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
-----------------------------------------------------------
(Updated March 21, 2014, 2:59 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-227
https://issues.apache.org/jira/browse/AURORA-227
Repository: aurora
Description
-------
AURORA-227: Aurora build should check for the Python version
Diffs
-----
build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12
build.gradle 9b8827ea05932620ebac4929838c158e853d73ae
Diff: https://reviews.apache.org/r/18537/diff/
Testing
-------
Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in:
:checkPythonVersion FAILED
FAILURE: Build failed with an exception.
* Where:
Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257
* What went wrong:
Execution failed for task ':checkPythonVersion'.
> Build requires Python 2.6 or Python 2.7
Thanks,
Dan Norris