You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:39:20 UTC
[GitHub] [celix] pnoltes opened a new pull request #227: Update build documentation for Ubuntu.
pnoltes opened a new pull request #227:
URL: https://github.com/apache/celix/pull/227
The used FetchContent CMake command requires cmake 3.11+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a change in pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #227:
URL: https://github.com/apache/celix/pull/227#discussion_r425333471
##########
File path: documents/building/README.md
##########
@@ -66,6 +66,11 @@ sudo apt-get install -yq --no-install-recommends \
#required if the ENABLE_TESTING option is enabled
sudo apt-get install -yq --no-install-recommends \
libcpputest-dev
+
+#For testing gtest is also used. This is fetched using a cmake 3.11+ feature,
Review comment:
Yes, already mentioned by Roy and updated to 3.13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #227:
URL: https://github.com/apache/celix/pull/227#issuecomment-626377242
> As can be seen in [Alexander's PR](https://github.com/apache/celix/pull/228/files#diff-af3b638bc2a3e6c650974192a53c7291), the minimum is actually 3.14.
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink merged pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
rlenferink merged pull request #227:
URL: https://github.com/apache/celix/pull/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
pnoltes commented on pull request #227:
URL: https://github.com/apache/celix/pull/227#issuecomment-628509350
@rlenferink and @abroekhuis : ping, could you review the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on a change in pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
rlenferink commented on a change in pull request #227:
URL: https://github.com/apache/celix/pull/227#discussion_r421648453
##########
File path: documents/building/README.md
##########
@@ -66,6 +66,11 @@ sudo apt-get install -yq --no-install-recommends \
#required if the ENABLE_TESTING option is enabled
sudo apt-get install -yq --no-install-recommends \
libcpputest-dev
+
+#For testing gtest is also used. This is fetched using a cmake 3.11+ feature,
+#The isntalled cmake version for Ubuntu 18 is older than 3.11,
Review comment:
Typo `isntalled` => `installed`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] Oipo commented on pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
Oipo commented on pull request #227:
URL: https://github.com/apache/celix/pull/227#issuecomment-626290959
As can be seen in [Alexander's PR](https://github.com/apache/celix/pull/228/files#diff-af3b638bc2a3e6c650974192a53c7291), the minimum is actually 3.14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] abroekhuis commented on a change in pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
abroekhuis commented on a change in pull request #227:
URL: https://github.com/apache/celix/pull/227#discussion_r421715550
##########
File path: documents/building/README.md
##########
@@ -66,6 +66,11 @@ sudo apt-get install -yq --no-install-recommends \
#required if the ENABLE_TESTING option is enabled
sudo apt-get install -yq --no-install-recommends \
libcpputest-dev
+
+#For testing gtest is also used. This is fetched using a cmake 3.11+ feature,
Review comment:
The FetchContent_MakeAvailable command even requires 3.14+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] abroekhuis commented on a change in pull request #227: Update build documentation for Ubuntu.
Posted by GitBox <gi...@apache.org>.
abroekhuis commented on a change in pull request #227:
URL: https://github.com/apache/celix/pull/227#discussion_r425335541
##########
File path: documents/building/README.md
##########
@@ -66,6 +66,11 @@ sudo apt-get install -yq --no-install-recommends \
#required if the ENABLE_TESTING option is enabled
sudo apt-get install -yq --no-install-recommends \
libcpputest-dev
+
+#For testing gtest is also used. This is fetched using a cmake 3.11+ feature,
Review comment:
Was an old remark, I always forget to post the review. Kinda used to adding it, and expecting it to be available. Instead of having to actually submit it ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org