You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/03 18:39:05 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2675: feat(frontend): add tapd config-ui
warren830 opened a new pull request, #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675
# Summary
add config-ui for tapd(only connections and advanced mode)
tapd.svg picture is not good....
### Does this close any open issues?
Please mention the issues here.
### Screenshots
<img width="451" alt="image" src="https://user-images.githubusercontent.com/39366025/182684347-14155f07-fbdd-4ef9-b860-1049e3b815d8.png">
<img width="1020" alt="image" src="https://user-images.githubusercontent.com/39366025/182684388-4338518f-77f7-45a6-add8-341f0a72e128.png">
<img width="907" alt="image" src="https://user-images.githubusercontent.com/39366025/182684546-0efae0ce-0836-4989-aeab-2d0cda484ad9.png">
<img width="1001" alt="image" src="https://user-images.githubusercontent.com/39366025/182684580-f21009d7-1339-4f39-a891-c0b3cc1a13da.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r939600073
##########
config-ui/src/images/integrations/tapd.svg:
##########
@@ -0,0 +1,6 @@
+<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937702477
##########
config-ui/src/images/integrations/tapd.svg:
##########
@@ -0,0 +1,6 @@
+<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
In order to make SVGs act properly as responsive React components, we need to make the width/height responsive. Manually edit this svg and set both `width=100` and `height=100` Leave the `viewBox` property the same. The correct size scaling will be applied when this svg is called by providerIcons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r939599863
##########
config-ui/src/data/Providers.js:
##########
@@ -59,6 +61,7 @@ const ProviderLabels = {
AE: 'Analysis Engine (AE)',
DBT: 'Data Build Tool (DBT)',
STARROCKS: 'StarRocks',
+ TAPD: 'Tapd',
Review Comment:
fixed
##########
config-ui/src/data/integrations.jsx:
##########
@@ -69,6 +70,24 @@ const integrationsData = [
/>
)
},
+ {
+ id: Providers.TAPD,
+ type: ProviderTypes.INTEGRATION,
+ enabled: true,
+ multiConnection: true,
+ name: ProviderLabels.TAPD,
+ icon: <TapdProvider className='providerIconSvg' width='30' height='30' style={{ float: 'left', marginTop: '5px' }} />,
+ iconDashboard: <TapdProvider className='providerIconSvg' width='40' height='40' />,
+ settings: ({ activeProvider, activeConnection, isSaving, isSavingConnection, setSettings }) => (
+ <JenkinsSettings
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r939599877
##########
config-ui/src/images/integrations/tapd.svg:
##########
@@ -0,0 +1,6 @@
+<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
Thanks, I just updated the `svg` with our own label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937688550
##########
config-ui/src/data/Providers.js:
##########
@@ -59,6 +61,7 @@ const ProviderLabels = {
AE: 'Analysis Engine (AE)',
DBT: 'Data Build Tool (DBT)',
STARROCKS: 'StarRocks',
+ TAPD: 'Tapd',
Review Comment:
Should "Tapd" be capitalized or uppercase "TAPD" like JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937688550
##########
config-ui/src/data/Providers.js:
##########
@@ -59,6 +61,7 @@ const ProviderLabels = {
AE: 'Analysis Engine (AE)',
DBT: 'Data Build Tool (DBT)',
STARROCKS: 'StarRocks',
+ TAPD: 'Tapd',
Review Comment:
Should "Tapd" **Label** be capitalized or uppercase "TAPD" like JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937702803
##########
config-ui/src/images/integrations/tapd.svg:
##########
@@ -0,0 +1,6 @@
+<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
```suggestion
<svg width="100" height="100" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937699149
##########
config-ui/src/data/integrations.jsx:
##########
@@ -69,6 +70,24 @@ const integrationsData = [
/>
)
},
+ {
+ id: Providers.TAPD,
+ type: ProviderTypes.INTEGRATION,
+ enabled: true,
+ multiConnection: true,
+ name: ProviderLabels.TAPD,
+ icon: <TapdProvider className='providerIconSvg' width='30' height='30' style={{ float: 'left', marginTop: '5px' }} />,
+ iconDashboard: <TapdProvider className='providerIconSvg' width='40' height='40' />,
+ settings: ({ activeProvider, activeConnection, isSaving, isSavingConnection, setSettings }) => (
+ <JenkinsSettings
Review Comment:
**TAPD** needs to use it's own `settings` component file, copy `settings/jenkins.jsx` to `settings/tapd.jsx`, update the Component definition and export names, and then import it and change this to `<TapdSettings .....`>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on code in PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#discussion_r937702477
##########
config-ui/src/images/integrations/tapd.svg:
##########
@@ -0,0 +1,6 @@
+<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
Review Comment:
In order to make SVGs act properly as responsive React components, we need to make the width/height responsive. Manually edit this svg and set both `width=100` and `height=100`. The correct size scaling will be applied when this svg is called by providerIcons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #2675: feat(frontend): add tapd config-ui
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #2675:
URL: https://github.com/apache/incubator-devlake/pull/2675#issuecomment-1208098871
@warren830 Please confirm Backend changes w/ @klesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org