You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2017/10/28 15:35:01 UTC
[jira] [Comment Edited] (YARN-7369) Improve the resource types docs
[ https://issues.apache.org/jira/browse/YARN-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223560#comment-16223560 ]
Daniel Templeton edited comment on YARN-7369 at 10/28/17 3:34 PM:
------------------------------------------------------------------
Thanks for the review, [~sunilg]!
# There's this line: {quote}Please note that the `resource-types.xml` and `node-resources.xml` files also need to be placed in same configuration directory as `yarn-site.xml` if they are used.{quote} It doesn't say that the files are new, but I was trying not to say that. By Hadoop 4.0, this doc will still be there, but they won't be new anymore.
# Yeah, the config and model sections both reference the properties, but the duplication is OK in my opinion. In the config section they're just enumerated, whereas the model section explains them in text. Basically the same content, but I don't see an issue in making it crystal clear. Would it help to add a statement in the config section that the preferred method is to place the new properties in the new config files?
# I'll add that.
was (Author: templedf):
Thanks for the review, @sunil!
# There's this line: {quote}Please note that the `resource-types.xml` and `node-resources.xml` files also need to be placed in same configuration directory as `yarn-site.xml` if they are used.{quote} It doesn't say that the files are new, but I was trying not to say that. By Hadoop 4.0, this doc will still be there, but they won't be new anymore.
# Yeah, the config and model sections both reference the properties, but the duplication is OK in my opinion. In the config section they're just enumerated, whereas the model section explains them in text. Basically the same content, but I don't see an issue in making it crystal clear. Would it help to add a statement in the config section that the preferred method is to place the new properties in the new config files?
# I'll add that.
> Improve the resource types docs
> -------------------------------
>
> Key: YARN-7369
> URL: https://issues.apache.org/jira/browse/YARN-7369
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: docs
> Affects Versions: 3.1.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-7369.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org