[GitHub] [trafficserver] bneradt commented on issue #7242: Logging continuously tries to delete logs

[GitBox <gi...@apache.org>]

bneradt commented on issue #7242:
URL: https://github.com/apache/trafficserver/issues/7242#issuecomment-704420534


   I've reproduced this in our prod sim by creating 10,000 files in the log directory that look like delete candidates. They are empty, so not much space is actually used, but they are inspected on each iteration. When the check is made on each iteration, I see a CPU spike.
   
   The candidates are stored as unique_ptr's here:
   https://github.com/apache/trafficserver/blob/master/proxy/logging/RolledLogDeleter.h#L71
   
   I'll see whether I can decrease the spike of CPU by implementing these candidates on the stack instead of via unique_ptr's.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org