[GitHub] flink pull request #6232: [FLINK-9695] [mesos] Add option for Mesos executor...

[lishim <gi...@git.apache.org>]

GitHub user lishim opened a pull request:

    https://github.com/apache/flink/pull/6232

    [FLINK-9695] [mesos] Add option for Mesos executor to forcefully pull Docker images

    ## What is the purpose of the change
    
    * This pull request introduces an option for Mesos executor to forcefully pull Docker images
    
    ## Brief change log
    
    * A new parameter ```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was introduced
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Added unit tests that verify correctness of behavior of new parameter
      - Manually verified behavior by running Flink in Mesos with Docker containerizer and 2 task managers.  Confirmed that when a task started on a node where the task image already resided, an existing cached image was used when ```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was left out or set to ```false```.  Confirmed that fresh image was pulled and used over a cached image when ```mesos.resourcemanager.tasks.container.docker.forcePullImage``` was set to ```true```.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? docs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lishim/flink feature/forcePullImage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6232
    
----
commit 2e6274b1f4f3692ae4bc57780ba3c4888e7123d6
Author: Leonid Ishimnikov <li...@...>
Date:   2018-06-30T05:34:23Z

    [FLINK-9695] Added mesos.resourcemanager.tasks.container.docker.forcePullImage option

----


---

[GitHub] flink issue #6232: [FLINK-9695] [mesos] Add option for Mesos executor to for...

[lishim <gi...@git.apache.org>]

Github user lishim commented on the issue:

    https://github.com/apache/flink/pull/6232
  
    Hi @tillrohrmann.  Thank you for your comment.  I have updated the code to conform to other configuration options.


---

[GitHub] flink pull request #6232: [FLINK-9695] [mesos] Add option for Mesos executor...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6232


---

[GitHub] flink pull request #6232: [FLINK-9695] [mesos] Add option for Mesos executor...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6232#discussion_r199331211
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java ---
    @@ -101,6 +101,12 @@
     		.withDescription("Custom parameters to be passed into docker run command when using the docker containerizer." +
     			" Comma separated list of \"key=value\" pairs. The \"value\" may contain '='.");
     
    +	public static final ConfigOption<Boolean> MESOS_RM_CONTAINER_DOCKER_FORCE_PULL_IMAGE =
    +		key("mesos.resourcemanager.tasks.container.docker.forcePullImage")
    --- End diff --
    
    In order to make it consistent with other configuration options, we should name this config option `force-pull-image`.


---