You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/05/22 08:11:44 UTC
Review Request: remove dead allocations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980
api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0
api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12
api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241
Diff: https://reviews.apache.org/r/11324/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request 11324: remove dead allocations
Posted by Devdeep Singh <de...@citrix.com>.
> On June 18, 2013, 6:08 a.m., Prasanna Santhanam wrote:
> > 93938ca716f85c24f2d9fb07c5856055f0061415
Dave, the request has been merged to master by Prasanna. Can you close this request.
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/#review22047
-----------------------------------------------------------
On June 17, 2013, 1:40 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11324/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 1:40 p.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980
> api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0
> api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241
>
> Diff: https://reviews.apache.org/r/11324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request: remove dead allocations
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/#review22047
-----------------------------------------------------------
Ship it!
93938ca716f85c24f2d9fb07c5856055f0061415
- Prasanna Santhanam
On June 17, 2013, 1:40 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11324/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 1:40 p.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Description
> -------
>
> code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980
> api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0
> api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241
>
> Diff: https://reviews.apache.org/r/11324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request: remove dead allocations
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/#review22040
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java
<https://reviews.apache.org/r/11324/#comment45376>
Can the result returned be null ?
- Nitin Mehta
On June 17, 2013, 1:40 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11324/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 1:40 p.m.)
>
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Description
> -------
>
> code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980
> api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0
> api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241
>
> Diff: https://reviews.apache.org/r/11324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request: remove dead allocations
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11324/
-----------------------------------------------------------
(Updated June 17, 2013, 1:40 p.m.)
Review request for cloudstack and Devdeep Singh.
Changes
-------
devdeep (ping)
Description
-------
code allocates a collection, and then immediately overwrites the reference variable holding that collection. That original collection is just a dead allocation, and is not needed - patch removes.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java b2d77b8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 69c6980
api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 75bcce0
api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12
api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java f0fc241
Diff: https://reviews.apache.org/r/11324/diff/
Testing
-------
Thanks,
Dave Brosius