You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/17 09:35:20 UTC

[GitHub] [iotdb] HTHou commented on a diff in pull request #7036: [IOTDB-4166] Fix select no files when time partition interval is too small

HTHou commented on code in PR #7036:
URL: https://github.com/apache/iotdb/pull/7036#discussion_r947687709


##########
server/src/main/java/org/apache/iotdb/db/engine/compaction/constant/InnerSequenceCompactionSelector.java:
##########
@@ -33,12 +34,15 @@ public static InnerSequenceCompactionSelector getInnerSequenceCompactionSelector
   }
 
   public IInnerSeqSpaceSelector createInstance(
-      String logicalStorageGroupName, String virtualStorageGroupName, long timePartition) {
+      String logicalStorageGroupName,
+      String virtualStorageGroupName,
+      long timePartition,
+      TsFileManager tsFileManager) {

Review Comment:
   virtualStorageGroupName -> dataRegionId ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org