[jira] [Commented] (GEODE-4151) Improper mixing of internal and external headers causes client compile issues.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301489#comment-16301489 ] 

ASF GitHub Bot commented on GEODE-4151:
---------------------------------------

pivotal-jbarrett opened a new pull request #173:  GEODE-4151: Fixes include search paths and statements.
URL: https://github.com/apache/geode-native/pull/173
 
 
   I found that early on we had mixed up the include paths in the CMake project so we were able to include private headers from the public headers. This will cause anyone trying to build a client to have a frustrating time since public won't be able to find private headers. I found this while experimenting with include what you use. The results here are a correction in the includes and forward declarations on the public headers and minimal include changes on the internal side. A more extensive include what you use run will need to be done on the internal sources later. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improper mixing of internal and external headers causes client compile issues.
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-4151
>                 URL: https://issues.apache.org/jira/browse/GEODE-4151
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Jacob S. Barrett
>
> Some public headers include private headers. Some public headers include items that do not need to be included. 
> Use include what you use tool to clean up includes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)