You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by interma <gi...@git.apache.org> on 2016/12/21 10:05:58 UTC

[GitHub] incubator-hawq pull request #1061: HAWQ-1226. fix compile error under gcc 4....

GitHub user interma opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1061

    HAWQ-1226. fix compile error under gcc 4.8.2

    When use gcc version **4.8.5** 20150623 (Red Hat 4.8.5-4) (GCC), there is a warning:
    ```
    be-secure.c:323:1: warning: 'report_commerror' defined but not used [-Wunused-function]
     report_commerror(const char *err_msg)
     ^
    ```
    
    But it will cause gcc 4.8.2 to make error if we remove this function. So let's keep it as before.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/interma/interma-hawq HAWQ-1226-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1061
    
----
commit d72e7b02e63a236260478c74090921036e43963d
Author: interma <in...@outlook.com>
Date:   2016-12-21T09:53:50Z

    HAWQ-1226. fix compile error under gcc 4.8.4

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1061: HAWQ-1226. fix compile error under gcc 4.8.2

Posted by interma <gi...@git.apache.org>.

Github user interma commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1061
  
    @linwen @huor thanks for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1061: HAWQ-1226. fix compile error under gcc 4.8.2

Posted by linwen <gi...@git.apache.org>.

Github user linwen commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1061
  
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1061: HAWQ-1226. fix compile error under gcc 4....

Posted by interma <gi...@git.apache.org>.

Github user interma closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1061


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1061: HAWQ-1226. fix compile error under gcc 4.8.2

Posted by interma <gi...@git.apache.org>.

Github user interma commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1061
  
    Finally found the root cause is not compiler version, but is configure option **--with-openssl**.
    So remove report_commerror() while enable this option at the same time will cause make error.
    
    Fix the similiar problem pls see: [#1062](https://github.com/apache/incubator-hawq/pull/1062)
    Thanks, @paul-guo- 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1061: HAWQ-1226. fix compile error under gcc 4.8.2

Posted by liming01 <gi...@git.apache.org>.

Github user liming01 commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1061
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---